backstage: 🐛 Bug Report: Github Discovery error

📜 Description

Problem started when upgrading from 1.7.2 to 1.8.3 and still persists when upgrading to 1.10.1

I’ve made the changes as advised regarding the naming from GitHub to Github but when the app starts on my local, I get the errors coming from my config for the Github Discovery feature.

I haven’t change anything from the config nor the Github App itself as it was working prior to 1.8.3. Did I miss something in the upgrade?

👍 Expected behavior

Github Discovery working and able to pull org data from public Github

👎 Actual Behavior with Screenshots

In the console, error reported the following

1] 2023-01-25T06:39:00.172Z catalog error github-provider:providerId refresh failed fetch failed type=plugin target=github-provider:providerId class=GithubEntityProvider taskId=github-provider:providerId:refresh taskInstanceId=ee0f1bf5-5275-4658-88de-b7f3af8d86bb name=HttpError status=500 request=[object Object] stack=HttpError: fetch failed
[1]     at /Users/yungc/Documents/Projects/backstage/node_modules/@octokit/request/dist-node/index.js:99:11
[1]     at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
[1]     at async hook (/Users/yungc/Documents/Projects/backstage/node_modules/@octokit/auth-app/dist-node/index.js:297:18)
[1]     at async Object.next (/Users/yungc/Documents/Projects/backstage/node_modules/@octokit/plugin-paginate-rest/dist-node/index.js:67:28)
[1]     at async GithubAppManager.getInstallationData (/Users/yungc/Documents/Projects/backstage/node_modules/@backstage/integration/dist/index.cjs.js:1311:30)
[1]     at async /Users/yungc/Documents/Projects/backstage/node_modules/@backstage/integration/dist/index.cjs.js:1278:45
[1]     at async Cache.getOrCreateToken (/Users/yungc/Documents/Projects/backstage/node_modules/@backstage/integration/dist/index.cjs.js:1228:34)
[1]     at async Promise.all (index 0)
[1]     at async GithubAppCredentialsMux.getAppToken (/Users/yungc/Documents/Projects/backstage/node_modules/@backstage/integration/dist/index.cjs.js:1349:21)
[1]     at async _SingleInstanceGithubCredentialsProvider.getCredentials (/Users/yungc/Documents/Projects/backstage/node_modules/@backstage/integration/dist/index.cjs.js:1399:17)

In the UI, Catalog Import returns the following error

{"error":{"name":"InputError","message":"Error: Unable to read url, HttpError: fetch failed","stack":"InputError: Error: Unable to read url, HttpError: fetch failed\n at DefaultLocationService.processEntities (/Users/yungc/Documents/Projects/backstage/node_modules/@backstage/plugin-catalog-backend/dist/index.cjs.js:2188:15)\n at process.processTicksAndRejections (node:internal/process/task_queues:95:5)\n at async DefaultLocationService.dryRunCreateLocation (/Users/yungc/Documents/Projects/backstage/node_modules/@backstage/plugin-catalog-backend/dist/index.cjs.js:2219:22)\n at async /Users/yungc/Documents/Projects/backstage/node_modules/@backstage/plugin-catalog-backend/dist/index.cjs.js:3512:22"},"request":{"method":"POST","url":"/locations?dryRun=true"},"response":{"statusCode":400}}

👟 Reproduction steps

Run Backstage upgrade as per instructed
Run yarn dev
Error is printed on the console

During runtime,

Go to catalog-import page.
Try to import a catalog
Observe error output on the screen

📃 Provide the context for the Bug.

No response

🖥️ Your Environment

OS: Darwin 22.2.0 - darwin/x64 node: v18.12.1 yarn: 1.22.19 cli: 0.22.1 (installed) backstage: 1.10.1

👀 Have you spent some time to check if this bug has been raised before?

I checked and didn’t find similar issue

🏢 Have you read the Code of Conduct?

I have read the Code of Conduct

Are you willing to submit PR?

None

About this issue

Original URL
State: closed
Created a year ago
Reactions: 1
Comments: 18 (10 by maintainers)

Most upvoted comments

For the interest of closure to this issue. I’ve finally managed to resolve it. Not by using undici package but a setting in Node.

export NODE_OPTIONS="--no-experimental-fetch"

This turns off the experimental fetch api in native node18 and uses the dependency package fetch module instead. This in-turns respects the proxy setting as per documentation. Avoid using experimental feature, I’d say. 😸

Source: https://github.com/node-fetch/node-fetch/issues/1566

darrenyung on Sep 13, 2023

OK I think i’m starting to understand what’s going on here. The bump to @octokit/request now will use the native implementation of fetch if it’s available, and it looks like that is the not being wrapped up in the http proxy stuff from global agent. https://github.com/octokit/request.js/pull/481

Then using this information, I had a look at the global-fetch repo and found this: https://github.com/gajus/global-agent/issues/52

Looks like there might be a workaround here at the bottom, but it’s not great. I think once we have the backend system we can maybe have the ability to have a fetch service that can be used everywhere that can add these settings so we wont need the global fetch anymore.

I’d look at trying to use that workaround to see if it works for you 🤞 and report back.

benjdlambert on Feb 3, 2023

Hmm yeah that’s interesting, I wonder if they’ve changed how they make requests from @octokit/request@5.6.3 -> @octokit/request@6.2.3 and now the global-agent doesn’t work anymore. If you can find out some more info or a possible route forward would be much appreciated 🙏

benjdlambert on Jan 30, 2023