minify: Don't use path.replaceWith() with a source string, use path.replaceWithSourceString()
ERROR in unknown: Don’t use path.replaceWith() with a source string, use path.replaceWithSourceString()
Seems to be the result of this change : https://github.com/babel/babili/pull/543/files
About this issue
- Original URL
- State: closed
- Created 7 years ago
- Reactions: 5
- Comments: 31 (8 by maintainers)
Commits related to this issue
- Should fix #576 People were calling `"foo".toString() or ["foo", "bar"].toString()`, which returned the real JS string `"[object Object]"`, the stringified version of the replacements object. — committed to j-f1/forked-babili by j-f1 7 years ago
- Fix #576 (#587) * Should fix #576 People were calling `"foo".toString() or ["foo", "bar"].toString()`, which returned the real JS string `"[object Object]"`, the stringified version of the replace... — committed to babel/minify by j-f1 7 years ago
Is this on npm yet? Asking because i still get this error message.
@michaeltrim Can you try replacing
node_modules/babel-plugin-minify-constant-folding/lib/index.jswith this patched version to see if that fixes it?@j-f1 That has fixed the error when running yarn run build-main, thank you.
yarn run package still doesn’t complete but this may be unrelated just doing some investigation and will let you know.
New version is released now with this fix https://github.com/babel/babili/releases/tag/babili%400.1.4
Awesome, fingers crossed the fix version won’t be long On Tue, 20 Jun 2017 at 08:56 damiano.barbati notifications@github.com wrote: