go-autorest: Azure go-autorest causing ambiguous import
Got an ambiguous import error when run go get ./… under a go module enabled project:
build github.com/.../cmd/manager: cannot load github.com/Azure/go-autorest/autorest: ambiguous import: found github.com/Azure/go-autorest/autorest in multiple modules:
github.com/Azure/go-autorest v11.2.8+incompatible (/go/pkg/mod/github.com/!azure/go-autorest@v11.2.8+incompatible/autorest)
github.com/Azure/go-autorest/autorest v0.3.0 (/go/pkg/mod/github.com/!azure/go-autorest/autorest@v0.3.0)
go-autorest is introduced by client-go. here is the line in my go.mod:
github.com/Azure/go-autorest/autorest v0.3.0 // indirect
but in the go.sum, there are many lines:
github.com/Azure/go-autorest v11.2.8+incompatible h1:Q2feRPMlcfVcqz3pF87PJzkm5lZrL+x6BDtzhODzNJM=
github.com/Azure/go-autorest v11.2.8+incompatible/go.mod h1:r+4oMnoxhatjLLJ6zxSWATqVooLgysK6ZNox3g/xq24=
github.com/Azure/go-autorest/autorest v0.3.0 h1:yOmXNB2qa2Kx40wMZB19YyafzjCHacXPk8u0neqa+M0=
github.com/Azure/go-autorest/autorest v0.3.0/go.mod h1:AKyIcETwSUFxIcs/Wnq/C+kwCtlEYGUVd7FPNb2slmg=
github.com/Azure/go-autorest/autorest/adal v0.1.0 h1:RSw/7EAullliqwkZvgIGDYZWQm1PGKXI8c4aY/87yuU=
github.com/Azure/go-autorest/autorest/adal v0.1.0/go.mod h1:MeS4XhScH55IST095THyTxElntu7WqB7pNbZo8Q5G3E=
github.com/Azure/go-autorest/autorest/date v0.1.0/go.mod h1:plvfp3oPSKwf2DNjlBjWF/7vwR+cUD/ELuzDCXwHUVA=
github.com/Azure/go-autorest/autorest/mocks v0.1.0/go.mod h1:OTyCOPRA2IgIlWxVYxBee2F5Gr4kF2zd2J5cFRaIDN0=
github.com/Azure/go-autorest/logger v0.1.0/go.mod h1:oExouG+K6PryycPJfVSxi/koC6LSNgds39diKLz7Vrc=
github.com/Azure/go-autorest/tracing v0.1.0/go.mod h1:ROEEAFwXycQw7Sn3DXNtEedEvdeRAgDr0izn4z5Ij88=
About this issue
- Original URL
- State: closed
- Created 5 years ago
- Comments: 20 (12 by maintainers)
Commits related to this issue
- Fix ambiguous import errors when consuming modules For nested modules, add a dummy import to its parent module under the "modhack" build constraint. For more details please refer to issue https://gi... — committed to jhendrixMSFT/go-autorest by jhendrixMSFT 5 years ago
- Fix ambiguous import errors when consuming modules (#455) For nested modules, add a dummy import to its parent module under the "modhack" build constraint. For more details please refer to issue h... — committed to Azure/go-autorest by jhendrixMSFT 5 years ago
- Update go mod tidy (and fix for Azure/go-autorest & azure-sdk-for-go) See https://github.com/coredns/coredns/pull/3209#issuecomment-525016357 for the previous issues, also see https://github.com/Azur... — committed to coredns/coredns by yongtang 5 years ago
- Update go mod tidy (and fix for Azure/go-autorest & azure-sdk-for-go) See https://github.com/coredns/coredns/pull/3209#issuecomment-525016357 for the previous issues, also see https://github.com/Azur... — committed to coredns/coredns by yongtang 5 years ago
- Update go mod tidy (and fix for Azure/go-autorest & azure-sdk-for-go) (#3258) See https://github.com/coredns/coredns/pull/3209#issuecomment-525016357 for the previous issues, also see https://github... — committed to coredns/coredns by yongtang 5 years ago
- Pinned go-autorest to v13.3.3 Azure/go-autorest version less than v12.0.0 causes ambiguous imports. Though it's not agola direct dependency, it causes problem when others use agola.io/agola as depend... — committed to patcito/agola by cuonglm 4 years ago
- Pinned go-autorest to v13.3.3 Azure/go-autorest version less than v12.0.0 causes ambiguous imports. Though it's not agola direct dependency, it causes problem when others use agola.io/agola as depend... — committed to patcito/agola by cuonglm 4 years ago
- Pinned go-autorest to v13.3.3 Azure/go-autorest version less than v12.0.0 causes ambiguous imports. Though it's not agola direct dependency, it causes problem when others use agola.io/agola as depend... — committed to patcito/agola by cuonglm 4 years ago
- Pinned go-autorest to v13.3.3 Azure/go-autorest version less than v12.0.0 causes ambiguous imports. Though it's not agola direct dependency, it causes problem when others use agola.io/agola as depend... — committed to patcito/agola by cuonglm 4 years ago
- Pinned go-autorest to v13.3.3 Azure/go-autorest version less than v12.0.0 causes ambiguous imports. Though it's not agola direct dependency, it causes problem when others use agola.io/agola as depend... — committed to patcito/agola by cuonglm 4 years ago
- Pinned go-autorest to v13.3.3 Azure/go-autorest version less than v12.0.0 causes ambiguous imports. Though it's not agola direct dependency, it causes problem when others use agola.io/agola as depend... — committed to patcito/agola by cuonglm 4 years ago
- Pin version of Azure/go-autorest to > v12.0.1 * This version split the library into many mini-modules * Having some of our upstream dependencies use an older version led to `ambiguos import` errors, ... — committed to cloudfoundry/capi-k8s-release by deleted user 4 years ago
- Fix Go module ambiguous import errors (#528) * Fix Go module ambiguous import errors This is an extension of the mitigations introduced in #455. Unfortunately, the original mitigations didn't add... — committed to Azure/go-autorest by miquella 4 years ago
- Dev -> Master (#532) * Deserialize additionalInfo in ARM error * Allow a new authorizer to be created from a configuration file by specifying a resource instead of a base url. This enables reso... — committed to Azure/go-autorest by jhendrixMSFT 4 years ago
- reflex: Fix module dep issue Summary: Got this error when running `go mod tidy`: ``` github.com/luno/reflex/rblob tested by github.com/luno/reflex/rblob.test imports gocloud.dev/blob/s3blob tested ... — committed to luno/reflex by corverroos 4 years ago
- autorest: remove testing.T.Fatal() from test goroutine (#511) * Deserialize additionalInfo in ARM error * Allow a new authorizer to be created from a configuration file by specifying a resource in... — committed to Azure/go-autorest by alrs 4 years ago
- Merge dev into master (#545) * Deserialize additionalInfo in ARM error * Allow a new authorizer to be created from a configuration file by specifying a resource instead of a base url. This enab... — committed to Azure/go-autorest by jhendrixMSFT 4 years ago
A
replacedirective should never be necessary. A more appropriate resolution would be to modify the nested modules torequirea version (or pseudo-version) of the parent module that removes the ambiguous package.(See, for example, the requirement on
cloud.google.com/goin https://code-review.googlesource.com/c/gocloud/+/43891.)That sounds right. You only need the reverse edge to remove ambiguous packages, so if there are no such packages to remove then you’re good without it.
@bcmills you’re right, using
replacewas bad advice and I admit it stems from still not fully understanding how modules interact with pre-modules dependencies. I’m looking at the reference you provided and read the associated wiki section. To make sure I correctly understand, I’d want to update module./autorest/validationto have a dependency on its parent module./autorest, and apply this same logic to all sub-modules. Going forward does that mean that every time a parent module has a minor/patch update all of its sub-modules must be updated to require the new version? Can this “fake” requirement ever be removed (perhaps in v2+)?