azure-sdk-for-js: [Service Bus] Attempt to settle msg after session lock expiry yields unhelpful error messages

That’s right, the user’s onError handler would be invoked in such cases and that needs to be understood by the user maybe. Unlike, say, regular promise’s reject, resolve callbacks, our callbacks are not mutually exclusive. That may need to change or perhaps just documented? Yes, whenever there’s an error the onError handler gets invoked one way or the other. If onMessage throws error only then would onMessage stop executing.

Update - with https://github.com/Azure/azure-sdk-for-js/pull/1128:

• Updated session lock renewal tests
• Testing done:
  • All the tests pass, including lock related ones (glad to see this! they took 1hr 18 min to complete)

Pending items:

• Continued deep-dive on credits and credit_window
  • the error does not get triggered if we add credit at the beginning of onSessionMessage handler. Could be related to - https://github.com/amqp/rhea-promise/blob/c82884b80852619d8ec31e976127a01174d412db/lib/util/utils.ts#L179
• Error handling in streaming receiver revisit or documentation update perhaps

These errors are thrown by the SDK even before the message settle request is made to Service Bus.

We need to understand 2 things here

• Understand how the remote_settled property got set to true
• Understand how the there is no more receiver

One possible fix is to check the sessionLockedUntilUtc before either of these errors are thrown. If current time is greater than sessionLockedUntilUtc, then we can throw a better error message.