axios: Axios does not use data from config when making DELETE request

Describe the bug

Axios last version (0.20.0) does not use data from config when making DELETE request. In 0.19.2 it’s working fine

To Reproduce

axios.delete("...", { 
    data: { ids: [...] },
}).then(response => {
    ...
}).catch(error => {
    ...
});

Expected behavior

Axios send request data from config when making DELETE request

Environment

Axios Version 0.20.0
Browser Chrome
Browser Version 84.0.4147.125
Node.js Version 12.18.3
OS: Linux Mint
Additional Library Versions React 16.13.1

Additional context/Screenshots

None

About this issue

Original URL
State: closed
Created 4 years ago
Reactions: 71
Comments: 19 (1 by maintainers)

Commits related to this issue

fix(external): pin axios to 0.19 to avoid breaking bug in 0.20 https://github.com/axios/axios/issues/3220 — committed to wopian/kitsu by wopian 4 years ago
fix(external): pin axios to 0.19 to avoid breaking bug in 0.20 https://github.com/axios/axios/issues/3220 — committed to wopian/kitsu by wopian 4 years ago
Downgrade axios to 0.19 See https://github.com/axios/axios/issues/3220 — committed to nawhas/nawhas by szainmehdi 4 years ago
Axios downgraded to 0.19.2 Wait for https://github.com/axios/axios/issues/3220 resolution — committed to karaokemugen/karaokemugen-app by Aeden-B 4 years ago
Axios downgraded to 0.19.2 Wait for https://github.com/axios/axios/issues/3220 resolution — committed to karaokemugen/karaokemugen-app by Aeden-B 4 years ago
fix(auth): fix security issue in authentication - revert @nestjs/common to 7.4.2 to force using axios 0.19.2 (cf. https://github.com/axios/axios/issues/3220) — committed to nohanna/swingify by nohanna 4 years ago

Most upvoted comments

I’m getting this same issue. It took a long time to figure out it was an issue with the package, this is probably a relatively urgent fix.

+21

ggaabe on Aug 27, 2020

FYI the following is a work around until this is fixed

axios.request({
      ...config,
      method: 'delete',
      url,
      data
})

+20

tim-field on Sep 8, 2020

This seems worthy of cutting 0.20.1 to release sooner than later.

+18

dball on Sep 28, 2020

This broke multiple endpoints in subtle ways for us when updating Axios and took some time to identify. I hope for the sake of other companies that this issue is resolved quickly.

+13

blixt on Sep 1, 2020

Hi,

Version 0.21.0 has been released 🎉 please use that and let us know if that solves your issue.

Thanks

jasonsaayman on Oct 23, 2020

I also meet this problem

14glwu on Sep 3, 2020

Tested in runkit and confirmed. It is really a breaking change.

version	axios	axios.delete
0.18.0	has data	has data
0.19.0/1/2	has data	has data
0.20.0	has data	no data

The reason is that mergeConfig always selects the next data. For other aliases with data(like post/put/patch), it is reasonable. But for aliases without data, the original utils.merge is better. We should fix it in the next release with some tests.

// lib/core/Axios.js
utils.forEach(['delete', 'get', 'head', 'options'], function forEachMethodNoData(method) {
  /*eslint func-names:0*/
  Axios.prototype[method] = function(url, config) {
    return this.request(mergeConfig(config || {}, {
      method: method,
      url: url
    }));
  };
});

utils.forEach(['post', 'put', 'patch'], function forEachMethodWithData(method) {
  /*eslint func-names:0*/
  Axios.prototype[method] = function(url, data, config) {
    return this.request(mergeConfig(config || {}, {
      method: method,
      url: url,
      data: data
    }));
  };
});

chinesedfan on Aug 22, 2020

@sparkxxxxxx DELETE with a body (data) is part of the HTTP spec.

https://tools.ietf.org/html/rfc7231#section-4.3.5

wopian on Sep 6, 2020

Hi,

Version 0.21.0 has been released 🎉 please use that and let us know if that solves your issue.

Thanks

Can confirm issue is fixed for us.

dmbarry86 on Oct 26, 2020

Kindly invite someone to test with #3282. Hope it solves the problem.

chinesedfan on Sep 12, 2020

@chinesedfan I built #3282 from source and patched it into node_modules and our 6 failing DELETE tests that mock endpoint responses with data now pass 👍

wopian on Sep 12, 2020

@wopian I’m with you.

zhangyy62 on Sep 8, 2020

Same problem for me, I had to revert my package-lock.json to understand what was going on.

nohanna on Sep 4, 2020