ssosync: Breaking change on v1.0.0-rc.9 (from v1.0.0-rc.8)
Describe the bug
When running ssosync v1.0.0-rc.8, the process works fine. When running v1.0.0-rc.9 with the exact same set of parameters, it exits with an error.
To Reproduce Steps to reproduce the behavior:
- Download v1.0.0-rc.8
- Run with:
./ssosync \
--debug \
--access-token "REDACTED" \
--endpoint "REDACTED" \
--google-admin "REDACTED" \
--google-credentials "credentials.json"
-
See the correct output running the sync.
-
Download v1.0.0-rc.9
-
Run with the exact same commands as before
-
See the error:
INFO[0000] Syncing AWS users and groups from Google Workspace SAML Application
INFO[0000] syncing sync_method=groups
DEBU[0000] get google groups query=
FATA[0000] googleapi: Error 400: Invalid Input: query, invalid
Expected behavior Expected v1.0.0-rc.9 to not have any breaking changes from v1.0.0-rc.8, as none are documented, and this is not a major version bump.
To be very clear: a bump such as rc.8 -> rc.9 should have absolutely identical behavior for a valid set of parameters. Anything different than that makes it a breaking change, which doesn’t belong to something like rc.8 -> rc.9.
Additional context Running on Mac OS 11.2.3.
About this issue
- Original URL
- State: closed
- Created 3 years ago
- Reactions: 9
- Comments: 27 (11 by maintainers)
Commits related to this issue
- Fixed issue #40 related to FATA[0003] status of http response was 404 when --sync-method 'groups' — committed to christiangda/ssosync by christiangda 3 years ago
- Fixed issue #40 related to FATA[0003] status of http response was 404 when --sync-method 'groups' — committed to janetechinc/ssosync by christiangda 3 years ago
6 months have passed still neither got an update rx10 nor a fix for rc9 breaking changes
@joshuachong — maybe it’s time to revert back to rc.8, and delete release rc.9?
(edit: just to make it clear that the PR #47 linked above called “Fixed issue #40 […]” doesn’t fix the issue, and in fact makes things a bit worse as it brings destructive behavior; I added a comment on the PR about it)
It’s been quite a long time and this is still an ongoing issue, and the more time passes, the more people will start using rc.9 as their first contact with
ssosyncand those will be negatively impacted when that (broken) behavior ends up being reverted…I’d suggest also adding proper automated tests for all default behavior to prevent something like this from happening in the future, as it’s quite disruptive.
Totally agree.
But this isn’t tagged Alpha. Not even Beta. It’s a Release Candidate. It should be considered stable enough as a potential Release.
Removing features and changing defaults shouldn’t even be considered at this point.
It surprises me that someone would propose a PR doing that, and probably even more so that such a PR would be accepted and merged.
The longer @christiangda and @joshuachong take to fix this, the worst this situation becomes, as now there’s a set of features and a default behavior in rc8 that are completely different than in rc9. The longer this mess goes on, the more people will start with rc9 and the more people will then be similarly negatively affected by fixing the mess introduced in rc9.
I’m still on the previous release and never upgraded due to this issue