router: deactivate() does not invoked after navigate to other router module.
@xiwc commented on Fri Aug 19 2016
I’m submitting a bug report
- Library Version: “aurelia-framework”: “^1.0.0-rc.1.0.0”,
Please tell us about your environment:
- Operating System: Windows [7|10]
- Node Version: v4.4.2
- NPM Version: 3.10.5
- JSPM OR Webpack AND Version webpack 1.13.1
- Browser: Chrome 52.0.2743.116 m
- Language: ESNext
Current behavior: when i switch router.
#/server/disk -> #/server/otherdeactivate() is invoked normally#/server/disk -> #/network/otherdeactivate() is not invoked normally
@guilhermewaess commented on Tue Sep 13 2016
Are you using layouts? I have the same problem, but with attached() <- attached() never calls when I using layouts 😦
@alpox commented on Wed Sep 14 2016
Seems to be a duplicate of https://github.com/aurelia/templating-router/issues/34
About this issue
- Original URL
- State: closed
- Created 8 years ago
- Reactions: 3
- Comments: 15 (6 by maintainers)
Commits related to this issue
- 411 bug fix - deactivate() does not invoked after navigate to other router module https://github.com/aurelia/router/issues/411 — committed to MT-PL-SWF-Dev/router by MT-PL-SWF-Dev 7 years ago
I am running into this as well. This is a pretty serious issue (imo) as it can cause some really bad bugs (with memory leaks etc. as observers are usually unsubscribed in deactivate etc.)
as of today
deactivate()is not being called on some standard router route changes.Yeah, that is sad because both those bugs are pretty annoying sometimes. I don’t get this code enough to PR it.
@m-andrew-albright this is live in 1.4.0 since Oct 2. Thanks for your patience.
Do we have any idea how soon this fix will trickle down into a release? This will be huge for my team.