minimap: Uncaught TypeError: Invalid Point: (NaN, 0)

This is easily reproducible for me when ever you right click on a tab and choose “split left”, no split happens but when I restart the split is now visible

I use splits frequently and this is really obnoxious. Can this be prioritized for the next release?

Same error on “split left” for tab. When restart, load splited without any issue.

Released v4.29.7 with the fix. Let us know if this is still an issue.

I have had this issue occur in 1.20.0

@mehcode mehcode-possible-fix-626 work for me,thx! btw,I’m using 1.21.0-beta0 on mac

+1

+1

[Enter steps to reproduce:]

1. Open a file
2. Click anywhere on it

Atom: 1.19.4 x64 Electron: 1.6.9 OS: Mac OS X 10.12.6 Thrown From: minimap package 4.29.6

Stack Trace

Uncaught TypeError: Invalid Point: (NaN, 0)

At /Applications/Atom.app/Contents/Resources/app/node_modules/text-buffer/lib/point.js:63

TypeError: Invalid Point: (NaN, 0)
    at Function.module.exports.Point.assertValid (/Applications/Atom.app/Contents/Resources/app/node_modules/text-buffer/lib/point.js:63:21)
    at DisplayLayer.translateScreenPosition (/Applications/Atom.app/Contents/Resources/app/node_modules/text-buffer/lib/display-layer.js:333:17)
    at DisplayLayer.clipScreenPosition (/Applications/Atom.app/Contents/Resources/app/node_modules/text-buffer/lib/display-layer.js:391:18)
    at TextEditor.module.exports.TextEditor.clipScreenPosition (/Applications/Atom.app/Contents/Resources/app/src/text-editor.js:1794:38)
    at HTMLElement.pixelPositionForScreenPosition (/Applications/Atom.app/Contents/Resources/app/src/text-editor-element.js:242:38)
    at StableAdapter.computeScrollTop (/packages/minimap/lib/adapters/stable-adapter.js:60:42)
    at StableAdapter.getScrollTop (/packages/minimap/lib/adapters/stable-adapter.js:51:17)
    at Minimap.getTextEditorScrollRatio (/packages/minimap/lib/minimap.js:598:25)
    at Minimap.getCapedTextEditorScrollRatio (/packages/minimap/lib/minimap.js:610:29)
    at Minimap.getScrollTopFromEditor (/packages/minimap/lib/minimap.js:937:12)
    at Minimap.getScrollTop (/packages/minimap/lib/minimap.js:887:14)
    at Minimap.getLastVisibleScreenRow (/packages/minimap/lib/minimap.js:865:13)
    at Minimap.emitRangeChanges (/packages/minimap/lib/mixins/decoration-management.js:504:38)
    at Minimap.emitDecorationChanges (/packages/minimap/lib/mixins/decoration-management.js:489:10)
    at Minimap.removeAllDecorationsForMarker (/packages/minimap/lib/mixins/decoration-management.js:583:14)
    at /packages/minimap/lib/mixins/decoration-management.js:349:14)
    at Function.module.exports.Emitter.simpleDispatch (/Applications/Atom.app/Contents/Resources/app/node_modules/event-kit/lib/emitter.js:25:20)
    at Emitter.module.exports.Emitter.emit (/Applications/Atom.app/Contents/Resources/app/node_modules/event-kit/lib/emitter.js:141:34)
    at DisplayMarker.module.exports.DisplayMarker.didDestroyBufferMarker (/Applications/Atom.app/Contents/Resources/app/node_modules/text-buffer/lib/display-marker.js:28:26)
    at /Applications/Atom.app/Contents/Resources/app/node_modules/text-buffer/lib/display-marker-layer.js:54:29
    at Set.forEach (native)
    at DisplayMarkerLayer.module.exports.DisplayMarkerLayer.didClearBufferMarkerLayer (/Applications/Atom.app/Contents/Resources/app/node_modules/text-buffer/lib/display-marker-layer.js:53:46)
    at /Applications/Atom.app/Contents/Resources/app/node_modules/text-buffer/lib/marker-layer.js:104:28
    at Set.forEach (native)
    at MarkerLayer.module.exports.MarkerLayer.clear (/Applications/Atom.app/Contents/Resources/app/node_modules/text-buffer/lib/marker-layer.js:103:38)
    at DisplayMarkerLayer.module.exports.DisplayMarkerLayer.clear (/Applications/Atom.app/Contents/Resources/app/node_modules/text-buffer/lib/display-marker-layer.js:49:43)
    at DisplayMarkerLayer.module.exports.DisplayMarkerLayer.destroy (/Applications/Atom.app/Contents/Resources/app/node_modules/text-buffer/lib/display-marker-layer.js:37:18)
    at /packages/highlight-selected/lib/highlighted-area-view.coffee:195:19
    at Array.forEach (native)
    at HighlightedAreaView.module.exports.HighlightedAreaView.removeMarkers (/packages/highlight-selected/lib/highlighted-area-view.coffee:194:19)
    at HighlightedAreaView.removeMarkers (/packages/highlight-selected/lib/highlighted-area-view.coffee:1:1)
    at HighlightedAreaView.module.exports.HighlightedAreaView.handleSelection (/packages/highlight-selected/lib/highlighted-area-view.coffee:94:6)
    at HighlightedAreaView.handleSelection (/packages/highlight-selected/lib/highlighted-area-view.coffee:1:1)
    at /packages/highlight-selected/lib/highlighted-area-view.coffee:62:8

Commands

     -1:24 intentions:highlight (input.hidden-input)
     -1:24 core:copy (atom-notification.fatal.icon.icon-bug.native-key-bindings.has-detail.has-close.has-stack)

Non-Core Packages

angularjs 0.4.0 
atom-beautify 0.30.5 
atom-bracket-highlight 0.3.2 
atom-jump-block 0.5.4 
atom-wrap-in-tag 0.6.0 
autoclose-html 0.23.0 
autocomplete-module-import 0.1.1 
autocomplete-modules 1.7.0 
base16-ocean-dark-spacegray 0.13.0 
better-window-title 1.0.3 
busy-signal 1.4.3 
css-in-js 1.1.0 
cssbeautify 1.3.0 
editorconfig 2.2.2 
emmet 2.4.3 
file-icons 2.1.11 
highlight-selected 0.13.1 
import-cost-atom 1.0.4 
intentions 1.1.5 
js-func-viewer 1.1.4 
language-babel 2.73.0 
letter-spacing 0.3.1 
linter 2.2.0 
linter-eslint 8.2.1 
linter-ui-default 1.6.8 
minimap 4.29.6 
minimap-cursorline 0.2.0 
minimap-find-and-replace 4.5.2 
minimap-highlight-selected 4.6.1 
minimap-pigments 0.2.2 
minimap-quick-highlight 1.0.1 
oceanic-next 1.0.0 
open-project-file 1.1.1 
pigments 0.40.2 
platformio-ide-terminal 2.6.0 
react 0.16.2 
react-snippets 0.9.0 
single-click-open 0.2.2 
speed-bot 0.1.0 
sync-settings 0.8.3 
tree-view-open-files 0.3.0 
whitespacer 1.1.1 

I’m trying to reproduce this and I’m having trouble. I use minimap daily (with atom-beta, 1.21-0 as of now) and I’ve not seen this issue.

I’ve tried splitting left/right in various ways, from the tree view or from a tab.

I’ve tried using project manager and switching projects (sometimes that can corrupt state in weird ways) and doing this.

I’m afraid it’s hard to help without a reliable reproduction.

Regardless… from pure guesswork, we appear to have a data race going on, though it doesn’t appear to be a problem with minimap. The problem appears to be that sometimes getFirstVisibleScreenRow returns NaN. This is not a documented API. I’m guessing it returns NaN when there isn’t a visible screen row.

I filed #633 as an attempt to fix this. Can someone that gets this issue use that branch locally and let me know if it fixes the issue?

$ git clone https://github.com/atom-minimap/minimap
$ cd minimap
$ git checkout mehcode-possible-fix-626
$ npm i
$ apm link .

It is a little silly but if I quit and start atom - there ya go the new pane is aliive and well.

For now I have disabled minimap. I like it but not when i cannot do multipane editing conveniently.