github-for-jira: Draft pull requests trigger "Pull request created"

I understand that Draft pull requests are a fairly new feature, so maybe it’s just that the workflow hasn’t been entirely ironed out with how they work with the Jira integration.

That said, opening the discussion: I’m not sure if a draft pull request makes sense to trigger “Pull request created”. Right now we use that trigger to transition issues from “In Progress” to “In Review”, and I think the intent of a draft pull request is to signal code is still being developed, thus why it also does not trigger CODEOWNERS. I’m also open to suggestions on how to do the transition better if it sounds like I’m in the wrong ballpark.

Thanks!

About this issue

  • Original URL
  • State: closed
  • Created 5 years ago
  • Reactions: 140
  • Comments: 47 (4 by maintainers)

Most upvoted comments

Hi, any update on this issue?

Following up on the conversation, I rather not have the Pull Request be sent to Jira while it is a draft until it becomes ready for review.

@rachellerathbone we’re coming up on 4 years since GitHub introduced the draft feature (Feb 14). This thread is about the same age with no progress at all on the issue, or any communication about what Atlassian plans to do. Can you please give us some insight into this problem and what Atlassian’s intentions and timeline are for fixing this. Unfortunately I’m not able to comment in the Atlassian ticket posted earlier here, so this is the only outlet I’ve found.

Hi @dpraul. I’m from a team at Atlassian that is currently in the process of migrating the ownership over to us from GitHub. As a part of this, we’re currently going through the backlog of issues and prs to see what can still be addressed and what should be closed.

I’ve flagged this with the ‘to-triage’ label so my team can discuss. We’ll keep you posted on the status of this.

Hi all, we know you’ve been patiently waiting for this feature. We’re pleased to let you know it’s now in final testing stages and should be available soon. We’ll keep you posted on this issue and you can also follow the updates on this PR, stay tuned.

FYI - looks like some hero has opened a PR regarding this. Let’s give it some love ya’ll https://github.com/atlassian/github-for-jira/pull/1556

Any news about it?

Thanks @atrigueiro! Progress on this issue finally is much appreciated but I agree with @usmonster, this is only half the solution, since the “Pull request created” trigger is currently unaffected by this change. so I wouldn’t consider this issue resolved.

This issue is not resolved!

just had a check, the transition from draft to ready won’t trigger Pull request created again.

We can now check pullRequest.state for “draft” to avoid transitioning for those who are not following JIRACLOUD-78888, but the transiton from draft to ready for review PR should probably trigger “Pull request created”, if there is NO other way to detect this transition.

Thank you for the announcement @atrigueiro! I’m however not sure the new feature fulfills this issue’s core request (i.e. opening draft PR shouldn’t trigger “Pull request created” action). If this is the case, can you please reopen it? Thanks!

This feature should be configurable by the user. I dislike drafts triggering code review. It breaks peers reviewing each others work.

agree with last comment, is there any update?

It would be great to get it a) solved in general and b) also for Data Center solved.

I’m happy to announce this feature is now available for everyone! New draft PRs will now be highlighted as DRAFT in your Jira issues. Thanks so much for your patience and let us know what you think of the change.

Screenshot 2023-10-03 at 2 06 40 pm

It seems that Atlassian has their own ticket about this one. Probably helps more if people go there to vote the issue:

https://jira.atlassian.com/browse/JRACLOUD-72888

Still no update on this? Unable to comment as others have stated on the Atlassian thread.

To future people popping in here: feel free to comment if you have input! But simply commenting with a “+1” or similar “bump” comments does nothing except create noise for all the subscribers on this thread.

If you’d like to show your support but have nothing to add besides what has already been said, GitHub has a mechanism for your voice to be heard without creating additional noise! Simply leave a 👍 on the top comment and Atlassian will be able to see your input when they sort by “most reactions”. 🙂

+1

+1

Hi, any updates on this issue?

I also agree with @ivan-californias.

@tcbyrd what would happen if the status is set to UNKNOWN? Will it prevent the issue from transitioning but at the same time add it to the issue?

Have there been any improvements in JIRA’s API to tackle this issue better now?