danger-ruby-swiftlint: danger-swiftlint doesn't warn, while SwiftLint itself does

I’m not sure if this is some misconfiguration (mainly due to the fact there’s barely any configuration around danger-swiftlint… )

But when SwiftLint runs by itself, i see specifically

Todo Violation: TODOs should be avoided (...). (todo)

But when danger-swiftlint runs in my CI (Buddybuild), it doesn’t warn for some odd reason

Installing danger 5.3.3
Fetching danger-swiftlint 0.7.0
Installing danger-swiftlint 0.7.0 with native extensions
Bundle complete! 2 Gemfile dependencies, 22 gems now installed.
Bundled gems are installed into /tmp/sandbox/workspace/vendor/bundle.

Running Danger
Using Command Line: bundle exec danger --dangerfile=Dangerfile

Results:
    Warnings:
    - [ ] Big PR
    - [ ] The `Podfile` was updated

But no specific warnings related to SwiftLint, and I’m not exactly sure why or if I’m missing something.

Gemfile only has danger and danger-swiftlint

The portion of Dangerfile related to SwiftLint is:

# SwiftLint
swiftlint.config_file = '.swiftlint.yml'
swiftlint.binary_path = './Pods/SwiftLint/swiftlint'
swiftlint.lint_files
swiftlint.lint_files inline_mode: true

I’m wondering if this is related to the fact I’m using a pinned version with CocoaPods, but I don’t see why that would be an issue 🤔

Appreciate any help on this 😃

About this issue

  • Original URL
  • State: closed
  • Created 7 years ago
  • Reactions: 2
  • Comments: 16 (4 by maintainers)

Commits related to this issue

Most upvoted comments

Any news on this? swiftlint 0.22.0, still not working

This is not really fixed, but explained in the link I mentioned above. It is by design. Those who came here for a same question, I recommend to switch to danger-swiftlint written in swift. It is great!

@heidiproske, @ashfurrow answered the same question from me.

Will try to create a sample repo asap