jest-puppeteer: Take screenshot when a test fails
As suggested in #43, we would like to have a screenshot when a test fail, it is the same idea as #130.
Technical detail
- The screenshot would be created in a
.jest-puppeteer/screenshots
folder. - The name of the screenshot would be
${fileName}-${describe}-${it}-${timestamp}.png
We could redefine it
and test
but I think this is not the cleanest method. Any help from Jest team to do it properly is welcome @SimenB.
About this issue
- Original URL
- State: open
- Created 6 years ago
- Reactions: 45
- Comments: 40 (12 by maintainers)
Commits related to this issue
- fix(jest-environment-puppeteer): Class & Exports (#37647) * fix(jest-environment-puppeteer): Class & Exports This makes the typings actually compatible to create your own test environment and not... — committed to DefinitelyTyped/DefinitelyTyped by favna 5 years ago
- feat: take screenshot when a test fail Fix #131 — committed to argos-ci/jest-puppeteer by gregberge a year ago
- feat: take screenshot when a test fails Fix #131 — committed to argos-ci/jest-puppeteer by gregberge a year ago
It is amazing to see that everyone has a solution and nobody wants to make a PR, welcome in Wordpress world 🤗
Thought I’d share my solution to this, using jest-circus and extending the jest-puppeteer environment. It’s a little messy with the sleeps, I want to find a better way to handle that, but it works for now. Maybe jest-puppeteer can integrate with jest-circus out of the box once circus has more adoption and make this better.
@ricwal-richa yes,
takeScreenshot
was not part of my code sample so it’s normal you got this error. Here is the full code I use (this is typescript):+1 for a much needed feature
Here is how I did it:
Use this package: https://github.com/jeeyah/jestscreenshot
To come back at this issue, before I found this issue I had several attempts at this myself. My goal had higher ambitions though: I wanted jest to automatically generate a screenshot before and after each individual test. Disclaimer: I haven’t really used the jest API before, so this is probably the best thing I came up with:
Re-defining it is kinda ugly but it works better than all my other versions. Also I ignored
test
for now, because in my case I don’t need it. Now with Jest 24 the file can be specified insetupFilesAfterEnv
as part of an array. I’d really like to see such a feature soon in this project, and I would create a PR as well, it’s just that I’m not confident enough in my code. So if someone could nudge me into the right direction that would be great.@petrogad check if you’re not calling
jestPuppeteer.resetPage()
or doing something else with global page object inafterEach
/afterAll
. This was the reason I was getting blank screenshots.@neoziro I should be able to submit a PR with adapted solution of @testerez in following days
@AlexMarchini thanks for that! Perfect, I wanted to use jest-circus as well. If anyone else is wondering (or anyone has suggestions) like I was how to actually use this this is what my
jest-config.js
looks like:So I removed
preset
andjest-environment.js
is the above snippet. Andjest-setup.js
has nothing butrequire('expect-puppeteer');
in it.And that seems to be working… with jest-circus as the runner. (Note just run
yarn add --dev jest-circus
)Hope this helps someone.
@lucassardois PR was done but I had to migrate to TypeScript before. Will be done in the next weeks.
Maybe the PR to WordPress Gutenberg by @kevin940726 :
https://github.com/WordPress/gutenberg/pull/28449
…would provide a basis for a PR to the
jest-environment-puppeteer
package in this repo. Specifically, it seems to be this file that needs to be updated:https://github.com/smooth-code/jest-puppeteer/blob/master/packages/jest-environment-puppeteer/src/PuppeteerEnvironment.js
Incase it’s helpful, It seemed for me like the page was closed by the time jasmine reporter was called when using one of the above solutions, and overriding
it
prevents things likeit.only
from working. Ended up with this riff on @testerez’s code, which takes a screenshot after every test (on a CI env), but only saves the screenshot if the test fails: https://gist.github.com/ajs139/3ddc10e807ee9b94b581c80a762de587@testerez Thanks for the code! However, I cannot I get undefined error for the pageInstance variable.
I just put all the code (In javascript) in my setupTestFrameworkScriptFile file + a call to registerScreenshotReporter().
I modified the declaration for Vainilla as such:
export const takeScreenshot = (testName, pageInstance = page) => { ... }
And page is indeed the name of the page instance in my tests.In case someone wants to know how to get the test describe name when using
jest-circus
(https://github.com/smooth-code/jest-puppeteer/issues/131#issuecomment-493267937 saves a screenshot only with the test method name), you can get it like:I had to spend some time searching in the source code how
State
is defined insidejest-circus
to find that information, hope it helps someone 😄registerScreenshotReporter
should be called in the file you set assetupFilesAfterEnv
@testerez Thanks! Got it working.