argo-workflows: LifeCycle hooks phase not updated at workflow level
Summary
The phase of LifeCycle hooks configured at a workflow level are not updated once completed. They are stuck in pending
state forever.
This prevents workflows from being retried, which negatively impacts long running workflows with lots of steps
What happened/what you expected to happen?
Lifecycle hook phase should change to Succeeded
once completed
What version are you running?
v3.3.3
Impacted by this bug? Give it a ๐. We prioritise the issues with the most ๐.
About this issue
- Original URL
- State: closed
- Created 2 years ago
- Reactions: 14
- Comments: 32 (15 by maintainers)
Commits related to this issue
- fix: Workflow level http template hook status update. Fixes #8529 (#8586) * fix: Workflow level http template hook status update Signed-off-by: Saravanan Balasubramanian <sarabala1979@gmail.com> ... — committed to argoproj/argo-workflows by sarabala1979 2 years ago
- fix: Workflow level http template hook status update. Fixes #8529 (#8586) * fix: Workflow level http template hook status update Signed-off-by: Saravanan Balasubramanian <sarabala1979@gmail.com> * ... — committed to juchaosong/argo-workflows by sarabala1979 2 years ago
I still have the issue testing in
v3.4.0-rc4
where itโs supposed to have included the fix. cc: @sarabala1979hooks with expression
workflow.status == "Failed"
orworkflow.status == "Succeeded"
remains with PHASE=Pending despite they are being executed and finished fine.Should we open a new issue?
example:
Hi @alexec @sarabala1979 I have time to look into this issue. Itโs really effecting us, as we cant retry steps in long running workflows.
Should I create a new issue or can you reopen this one?
This has been affecting our team also. Seems like a fix is in, thanks @sarabala1979. Will it make 3.4?
Go is VERY easy to learn. It is designed to be. Took me about 3h to learn.