argo-events: Sensor triggers an Argo Workflow with wrong name
Describe the bug A GitLab push triggers a Workflow through a Sensor, the name of the repo and the revision should be used as Workflow name/title but actually it’s not. The repo name is concatenated with “the name of the previous Workflow”.
Se you can see in the screenshot above, the name of the last pipeline should be hdp-reader-master-xyz
but actually it is hdp-readercassandra-data-toolcassandra-data-tooldie-data-b4kmdp
, which is the concatenation of hdp-reader
and the name of the previous Workflow cassandra-data-toolcassandra-data-tooldie-data-back-fillerscr9d
(which is wrong as well).
Pods names are also wrong:
$ k get pods -n cicd-pipelines
NAME READY STATUS RESTARTS AGE
hdp-readercassandra-data-toolcassandra-data-tooldie-data-b4kmdp-1452109180 0/2 Completed 0 6m36s
hdp-readercassandra-data-toolcassandra-data-tooldie-data-b4kmdp-18957375 0/2 Completed 0 12m
hdp-readercassandra-data-toolcassandra-data-tooldie-data-b4kmdp-2296098792 0/2 Completed 0 5m36s
hdp-readercassandra-data-toolcassandra-data-tooldie-data-b4kmdp-2428497093 0/2 Completed 0 11m
hdp-readercassandra-data-toolcassandra-data-tooldie-data-b4kmdp-2763366116 0/2 Completed 0 13m
hdp-readercassandra-data-toolcassandra-data-tooldie-data-b4kmdp-2948167393 0/2 Completed 0 10m
hdp-readercassandra-data-toolcassandra-data-tooldie-data-b4kmdp-891922674 0/2 Error 0 7m36s
PLEASE NOTE
- This never happened in the previous version v1.4.0.
- It cannot be a GitLab issue as I checked webhook events and the repo name is correctly reported.
To Reproduce Steps to reproduce the behaviour:
- Configure a GitLab repo with a webhook pointing to your k8s cluster where Argo Events is deployed, exposed and ready to receive events
- Push anything to the GitLab repo and wait until the Workflow starts
- Try multiple times as it seems to happen after triggering 2 Workflows
- See weird Workflow name/title in the UI
Expected behavior
Workflow name should correspond to the repository name, in the example above hdp-reader-mater-xyz
should be the correct name.
Environment (please complete the following information):
- Kubernetes:
v1.21.5-gke.1302
- Argo:
v3.2.4
- Argo Events:
v1.5.3
Additional context Kubernetes cluster is provided by GKE (private cluster).
Message from the maintainers:
If you wish to see this enhancement implemented please add a 👍 reaction to this issue! We often sort issues this way to know what to prioritize.
About this issue
- Original URL
- State: closed
- Created 3 years ago
- Comments: 15 (15 by maintainers)
@daniel-codefresh I tested v1.5.6 and it looks that this bug has gone 😃) Thank you for your effort and the fix! Closing this issue.
@bygui86 @whynowy Found the bug an fixed it: #1511
@daniel-codefresh I’m going to test v1.5.6 before end of next week! Thanks for your patience!
@daniel-codefresh I hope to get a chance this or next week 🤞🏼 keep you posted!!
@daniel-codefresh amazing!! Waiting for a patch release 😃