architectury-loom: [1.10] ForgeMappingsMerger.resolveConflicts throws UnsupportedOperationException for Forge 1.20.1
I have a stonecutter project with yarn mappings, you can find it here (note: I’ve removed forge 1.20.1 for now, see settings.gradle) Today I updated from Loom 1.7 to 1.10 and can no longer load the Forge 1.20.1 project. I get this error:
java.lang.UnsupportedOperationException
at net.fabricmc.loom.util.srg.ForgeMappingsMerger.resolveConflicts(ForgeMappingsMerger.java:321)
at net.fabricmc.loom.util.srg.ForgeMappingsMerger.merge(ForgeMappingsMerger.java:178)
at net.fabricmc.loom.util.srg.ForgeMappingsMerger.mergeSrg(ForgeMappingsMerger.java:391)
at net.fabricmc.loom.configuration.providers.forge.ForgeLibrariesProvider.remapObjectHolder(ForgeLibrariesProvider.java:220)
at net.fabricmc.loom.configuration.providers.forge.ForgeLibrariesProvider.remapFmlLoader(ForgeLibrariesProvider.java:185)
at net.fabricmc.loom.configuration.providers.forge.ForgeLibrariesProvider.provide(ForgeLibrariesProvider.java:135)
at net.fabricmc.loom.configuration.CompileConfiguration.setupMinecraft(CompileConfiguration.java:234)
at net.fabricmc.loom.configuration.CompileConfiguration.lambda$run$2(CompileConfiguration.java:130)
Full output: https://paste.ee/p/ZtB21Cun
About this issue
- Original URL
- State: open
- Created 2 years ago
- Comments: 26 (1 by maintainers)
Commits related to this issue
- fix: disabled forge based tests until https://github.com/architectury/architectury-loom/issues/274 is resolved Signed-off-by: meza <211977+meza@users.noreply.github.com> — committed to meza/Stonecraft by meza 2 years ago
- Revert "fix: disabled forge based tests until https://github.com/architectury/architectury-loom/issues/274 is resolved" This reverts commit 2a3c0d4f0755ac22b695648a19af02be62b5659e. — committed to meza/Stonecraft by meza a year ago
It seems that this problem is caused by
mapping-iousingCollections.unmodifiableCollection()instead ofLinkedHashMap.values().https://github.com/FabricMC/mapping-io/commit/983c4274a6b34ae1b396b1c6f98963ebce4000ab
https://github.com/architectury/architectury-loom/blob/dev/1.10/src/main/java/net/fabricmc/loom/util/srg/ForgeMappingsMerger.java#L318-L323
https://github.com/FabricMC/mapping-io/blob/dev/src/main/java/net/fabricmc/mappingio/tree/MemoryMappingTree.java#L1118-L1121
Yup, Loom >1.7 just doesn’t work with Forge. And that’s quite problematic, since Loom 1.7 doesn’t support NeoForge 1.21.5 🙃