next-translate: Translations in shared layouts don't work anymore in 1.4.0
https://github.com/vinissimus/next-translate/pull/743 introduces the same bug reported here already: https://github.com/vinissimus/next-translate/issues/604
- also the author of https://github.com/vinissimus/next-translate/pull/743 already mentioned that the change back then was reverted because of https://github.com/vinissimus/next-translate/issues/604 and now the change in 1.4.0 is introducing the issue again
- we experience the same issue
steps to reproduce:
- use repo https://github.com/vinissimus/next-translate/issues/604
- use latest 1.4.0 next-translate version in package.json
- install dependency
- start the project with
yarn devand click on the links
About this issue
- Original URL
- State: closed
- Created 2 years ago
- Comments: 22 (17 by maintainers)
Commits related to this issue
- undo https://github.com/vinissimus/next-translate/pull/829 to resolve https://github.com/vinissimus/next-translate/issues/834 — committed to duc-gp/next-translate by duc-gp 2 years ago
- undo https://github.com/vinissimus/next-translate/pull/829 to resolve https://github.com/vinissimus/next-translate/issues/834 (#836) — committed to aralroca/next-translate by duc-gp 2 years ago
- Onboard custom i18n sol for page exit animations For reference see https://github.com/aralroca/next-translate/issues/834 — committed to project-millipede/millipede-docs by deleted user 2 years ago
- Onboard custom i18n sol for page exit animations For reference see https://github.com/aralroca/next-translate/issues/834 — committed to project-millipede/millipede-docs by deleted user 2 years ago
- undo https://github.com/vinissimus/next-translate/pull/829 to resolve https://github.com/vinissimus/next-translate/issues/834 (#836) — committed to Onengakushimoto/next_ai by Onengakushimoto 2 years ago
- undo https://github.com/vinissimus/next-translate/pull/829 to resolve https://github.com/vinissimus/next-translate/issues/834 (#836) — committed to HiraRyoko/next_ai by HiraRyoko 2 years ago
great news, thanks! who needs to add the tests? I havent really understood what the cases are… maybe we can also revert first with this PR https://github.com/vinissimus/next-translate/pull/836 and someone else delivers additional tests afterwards?