appsmith: [Bug] Table search not working with onSearchTextChanged
Description
For the table widget, if the onSearchTextChanged
action is defined the actual search functionality is not working anymore. The onSearchTextChanged
action itself is executed, but the search (filter) on the table is not applied.
Steps to reproduce the behaviour:
- Create a table widget with some data.
- Set
onSearchTextChanged
to some action (e.g. save the search value in the store or show a message) - Enter a search term. The search filter is not applied, but the action is executed.
- Remove the
onSearchTextChanged
action. - Enter a search term. The search filter is now applied.
Important Details
- Version: self-hosted, v1.5.5
- OS: Windows 10
- Browser: Chrome
- Environment: production
About this issue
- Original URL
- State: closed
- Created 3 years ago
- Comments: 18 (13 by maintainers)
Hi @Nikhil-Nandagopal sure, the issue is exactly like @WillemJann described earlier in this issue. In this image there is an action
onSearchTextChanged
specified and I’m searching for the text “Drop” which does not filter the results.When no
onSearchTextChanged
handler is specified the table is filteredWhat I want to happen, similar to @WillemJann is that client-side search is still done and the
onSearchTextChanged
handler can work, such that the search text can be remembered when the user e.g. reloads the page. I don’t want to do any server-side search in this case. I know you consider this behavior a feature as implemented in #4039 but this behavior was actually very helpful - I guess as long as one is not doing server side filtering.@Nikhil-Nandagopal going by the first logic and ignoring that we allowed such a use case should work fine. Shall we implement this, It not a lot of effort and can be picked up soon