appsmith: [Bug]: Error message on uploading Logo shows 100MB instead of 1MB

Is there an existing issue for this?

I have searched the existing issues

Description

Since uploading logo limit size is 1MB, but on it throws error message saying Payload too large: File size cannot exceed 100MB instead of 1MB as uploading file more than 1mb is not allowed

Screenshot (278)

Steps To Reproduce

create a application with multiple page
Go to App Settings> navigation> Upload Logo
Try to upload valid image larger than 1MB
Observe the error says 100MB instead of 1MB

Public Sample App

No response

Environment

Deploy Preview

Issue video log

No response

Version

Cloud

About this issue

Original URL
State: closed
Created a year ago
Comments: 18 (18 by maintainers)

Commits related to this issue

fix: fixed validation error for logo upload (#24006) ## Description > Incorrect validation error was shown when image size was greater than 1MB and less than 2MB. > Updated the file size compariso... — committed to appsmithorg/appsmith by harshitpandey0426 a year ago

Most upvoted comments

@dhruvikn I was able to test it, opened a PR please have a look

harshitpandey0426 on Jun 2, 2023

Awesome, assigning the issue to you. Let me know if you need any help. Thanks in advance, @harshitpandey0426!

dhruvikn on Jun 1, 2023

Hey @harshitpandey0426, thanks for taking a look at the issue. I saw your PR and disagree with the changes you have made. We don’t want to change the apiFailureResponseInterceptor’s limit to 1 MB. This function is called with all APIs and we have deliberately set the limit to 100 MB to avoid any large file uploads.

Coming back to the issue at hand, we need to triage why this is happening. It could be due to anything such as -

The frontend validation of the logo upload failed and allowed a file size bigger than 1 MB.
The backend validation failed for the same reason.
Or anything else.

If you’d still like to contribute, I would request you to triage the issue first and post your findings here. Based on that, we can come up with a plan and include all the relevant people (backend and/or product folks) in our conversation.

For now, I’m requesting changes to your PR to avoid merging.

cc: @somangshu, do you think we should close the PR instead?

dhruvikn on May 16, 2023