swift-nio-ssl: NIOSSL(Client|Server)Handler's init is throwing but that's not actionable
NIOSSLServerHandler’s init is throwing and that has two issues:
- it’s not really actionable so everybody writes
try! NIOSSLServerHandler(context: sslContext). If that’s what we want, we can just do that in the init. - it’s almost always used in the
clientChannelInitializerwhere you have to return a future…
About this issue
- Original URL
- State: open
- Created 5 years ago
- Comments: 17 (17 by maintainers)
Commits related to this issue
- Add support for custom verify callback to servers. Motivation: In #171 when we worked on providing access to the better verification callback, we managed to entirely miss that we had not provided th... — committed to Lukasa/swift-nio-ssl-1 by Lukasa 4 years ago
- Add support for custom verify callback to servers. Motivation: In #171 when we worked on providing access to the better verification callback, we managed to entirely miss that we had not provided th... — committed to Lukasa/swift-nio-ssl-1 by Lukasa 4 years ago
- Add support for custom verify callback to servers. (#226) Motivation: In #171 when we worked on providing access to the better verification callback, we managed to entirely miss that we had not p... — committed to apple/swift-nio-ssl by Lukasa 4 years ago
I checked with the NIO repository, just tried it on a separate throwing function there. We should get it hooked up here too really.
Thanks @wlisac! I think there also other such APIs that we should improve on.