apollo-client: client.resetStore() - Uncaught (in promise) Error when server returns an error

For my own case I found two possible solutions while using Apollo 3.3.21

Option A) adding a .catch on the resetStore

     <button
          onClick={() => {
            Cookie.remove("token");
            client.resetStore().catch((e) => {
              // do nothing or something or whatever you want
            });
          }}
        >
          Logout
    </button>

Option B) Instead of client.resetStore() use client.cache.reset() which clears the cache but does not refetch queries

        <button
          onClick={() => {
            Cookie.remove("token");
            client.cache.reset();
          }}
        >
          Logout
        </button>

@calebmer Is there a way to have it not refetch? For example when logging out, I sort of just want to kill everything. I’m running into issues where logging out -> logging in -> still has cached data from the logged out user.

Not sure if intentional, but I heard resetStore got some fixes recently, however I’m stuck on 0.5.21 due to the upgrading breaking updateQueries.

Sure. When resetting the store in QueryManager#resetStore we re-fetch every query we know of. ObservableQuery#refetch returns a promise and I bet that is where are uncaught error is coming from 😉

To fix this just have QueryManager#resetStore return a promise that resolves when all of the queries have been re-fetched and rejects when one of the queries rejects.

Anyone watching the queries that error will be notified through their observer.error handle. That’s probably where the error should really be handled. This change just allows the user to prevent unhandled promise rejections.

Another option would be to just ignore all errors from refetch as the errors will likely be handled elsewhere, but I think returning a promise is a better choice as it also allows the user to know when the reset has completed.