superset: supersetEmbeddedSdk filters.visible = false doesn't seem to work

A clear and concise description of what the bug is.

How to reproduce the bug

            dashboardUiConfig: { hideTitle: true, hideChartControls: true,
                filters: {
                    visible: false
                }
            },

Expected results

filter sidebar show not be visible

Actual results

filter sidebar is still visible, expanded: false does work though so it seems to be only visible that doesn’t take efect.

Screenshots

Environment

(please complete the following information):

browser type and version: Firefox 113 and Safari 16.4 both on macos

Using docker apache/superset:latest build yesterday

any feature flags active:

FEATURE_FLAGS = {
    "ALERT_REPORTS": True,
    "ENABLE_TEMPLATE_PROCESSING": True,
    "DASHBOARD_RBAC": True,
    "EMBEDDED_SUPERSET": True,
    "DASHBOARD_CROSS_FILTERS": True,
    "SQL_VALIDATORS_BY_ENGINE": True
}

Checklist

Make sure to follow these steps before submitting your issue - thank you!

I have checked the superset logs for python stacktraces and included it here as text if there are any.
I have reproduced the issue with at least the latest released version of superset.
I have checked the issue tracker for the same issue and I haven’t found one similar.

Additional context

Add any other context about the problem here.

About this issue

Original URL
State: closed
Created a year ago
Reactions: 3
Comments: 16 (4 by maintainers)

Commits related to this issue

[fix] Resolve issue #24195 — committed to apache/superset by john-bodley 8 months ago
fix: Resolve issue #24195 (#25804) — committed to apache/superset by john-bodley 8 months ago
fix: Resolve issue #24195 (#25804) (cherry picked from commit 8737a8a54669037473a89688b9029bc9f3b4ad09) — committed to apache/superset by john-bodley 8 months ago
3.0 (#3) * fix(sqllab): reinstate "Force trino client async execution" (#25680) * fix: remove unnecessary redirect (#25679) (cherry picked from commit da42bf2dbb82a40d5ffcc9bfdc46584cb36af616) ... — committed to 10webio/superset by saghatelian 7 months ago
fix: Resolve issue #24195 (#25804) — committed to CybercentreCanada/superset by john-bodley 8 months ago
fix: Resolve issue #24195 (#25804) — committed to sfirke/superset by john-bodley 8 months ago

Most upvoted comments

@matheusbsilva reading through https://github.com/apache/superset/pull/23228 it was likely removing show_filters was a mistake, i.e., I probably mistook it for show_native_filters.

john-bodley on Jun 23, 2023

It was indeed a feature, i was relying on it. After updating superset today, I got this issue.

herrlegno on Jun 21, 2023

Maybe this helps:

https://github.com/apache/superset/commit/eb805682e2d9b8ff6c4bda446e665d1045afe55f

filters.visible, filters.expanded **/ ```  <---

which no longer seems to be the case... there's also several posts in slack
about this... and even examples posted on how to hide filters...

Maybe that was always buggy and got removed... that much I don't know
because the release notes unfortunately don't mention this and I was lazy
to dig into more code or PRs etc

Anyway the fact is there is a lot of evidence to suggest this was indeed a
thing, and it no longer is, so if you want to set this as FR instead of BUG
I think it's fine, but it's definitely much needed, there's more than one
thread on slack, I just decided to bring it over Github because it seemed
like the correct approach perhaps it wasn't

mike-pt on Jun 14, 2023

Do we know what this bus is going to be fixed?

sebastiankruk on Sep 10, 2023

@matheusbsilva I can’t tell you for sure, because I cloned the repo not from dockerhub. I think it was 2.1.0rc1 because the reason for updating was the screenshot generation was broken. I hope this is helpful enough.

herrlegno on Jun 22, 2023