superset: Owner names not rendered in React Datasource editor
Expected results
The dataset owners should be rendered.
Actual results
How to reproduce the bug
- Go to a chart.
- Click on ‘Edit Datasource’
- Click on the ‘SETTINGS’ tab
- Scroll to the bottom and and noticed that the owner names aren’t rendered
Environment
(please complete the following information):
- superset version:
master - python version:
3.7 - node.js version:
12
Checklist
Make sure to follow these steps before submitting your issue - thank you!
- I have checked the superset logs for python stacktraces and included it here as text if there are any.
- I have reproduced the issue with at least the latest released version of superset.
- I have checked the issue tracker for the same issue and I haven’t found one similar.
About this issue
- Original URL
- State: closed
- Created 4 years ago
- Comments: 32 (31 by maintainers)
@junlincc I’m going to see if the issue is present in our internal weekly deploy which occurs on Wednesday. If it’s resolved it’s likely our last week branch cut did not contain the commit and I’ll close the issue, otherwise I’ll dig into this in more detail.
@etr2460 I don’t think my current implementation would work for the Datasource settings specifically. You can check the code in this PR https://github.com/apache/superset/pull/16609 that is related to the owners in the Datasource settings. Basically, we would need a refactor of the
SelectAsyncControlto work with the pagination. That PR is not merged yet so this might be a good opportunity to think about doing it, depending on prioritization OR we can increase the pagesize to a high limit as a quick fix as suggested above. CC @junlinccThere is another implementation which is using the paginated fetch instead and that’s in the Properties modal. I have an env with more than 10 owners (10 as a pagesize limit) and could not spot any problem. I am about to merge this PR containing the changes. This can be a good opportunity to validate this issue against the new implementation https://github.com/apache/superset/pull/16445.
@john-bodley I think that this issue might have been introduced by https://github.com/apache/incubator-superset/pull/11221. I’m not able to verify it as I can’t directly reproduce this bug with my test data. Is it possible that the new endpoint
api/v1/dataset/related/ownersreturns fewer owners than the old/users/api/readand your data actually uses the missing users? Could you please verify it? CC @lilykuang @junlincc@john-bodley thanks for the additional info we are looking into it!
@rusackas I believe this regression may be related to a recent change from Preset related to the Antd refactor.