kvrocks: Memory leaks in Lua::redisGenericCommand

Search before asking

• I had searched in the issues and found no similar issues.

Version

redisGenericCommand use raiseError to process errors, but raiseError will perform a longjmp in the lua_error api call, so raiseError never returns.

longjmp does not compatible with RAII in C++ (C++ exceptions may use longjmp in implementation but the compiler will insert some dtor call autometically and carefully, i.e. stack unwinding), so every object in the stack of redisGenericCommand will never be destroyed, i.e. no destructor will be call, hence all resource allocated in ctor like std::vector, std::unique_ptr etc. cannot be released.

@git-hulk

Minimal reproduce step

./runtest --dont-clean on a kvrocks binary with Address Sanitizer enabled. (try to build with #599) You can only run tests in unit/scripting to save time : )

What did you expect to see?

No memory leaks

What did you see instead?

Memory leaks are reported by Address Sanitizer

Anything Else?

No response

Are you willing to submit a PR?

• I’m willing to submit a PR!