datafusion: `stride` is not optional for new `array_slice` UDF
Describe the bug
The array_slice UDF takes 4 parameters.
Which means that args.len() is always 4 in array_slice_inner, even when called with stride = Expr::Null or stride = Expr::Int64(None)
To Reproduce
I encountered this while creating the python wrapper for datafusion-python and had to set stride=1 else the function would panic.
Expected behavior
The stride behavior in the UDF should match what’s available in the CLI
CREATE TEMPORARY VIEW data3 AS VALUES ([1.0, 2.0, 3.0, 3.0]), ([4.0, 5.0, 3.0]), ([6.0]);
❯ select * from data3;
+----------------------+
| column1 |
+----------------------+
| [1.0, 2.0, 3.0, 3.0] |
| [4.0, 5.0, 3.0] |
| [6.0] |
+----------------------+
> select * from array_slice(data3.column1, -1, 2)
+-----------------------------------------------+
| array_slice(data3.column1,Int64(-1),Int64(2)) |
+-----------------------------------------------+
| [] |
| [] |
| [6.0] |
+-----------------------------------------------+
Additional context
No response
About this issue
- Original URL
- State: closed
- Created 3 years ago
- Comments: 17 (17 by maintainers)
I submitted a formal PR #10469 to address this.
I recall hitting something like this with the substr/substring function. One would think they would be identical however they were not (since rust doesn’t do variadic functions nor does it allow defaults for args ala scala or Kotlin). For the substr it was expanded to two functions that internally used a vec<> and handled the logic of using the optional 3rd argument there.
First, I’d like to emphasize that if passing
stride=1to the UDF worked the same as not providing a stride in the SQL api, then this would be just porcelain / a nicety. Reposting the example from: https://github.com/apache/datafusion/issues/10425Now to this issue, I agree that I like the explicit arguments versus passing a
Vec, and I would hope the solution doesn’t require keeping two separate UDFs.I created a draft with what I would think is the natural rust solution in #10450. I don’t know if this violates some datafusion constraint, but all the tests pass.
If that is not possible, then a second proposal would be to amend
array_slice_innerw/ somenullcheck.But again, this is just a nice-to-have if passing
stride=1worked the same as not providing it in the SQL API.I agree it is helpful if we support
expr_fn::array_slice(array, begin, end). We can’t only provide three args for it nowBut I can’t think of any good solution to this
What you are expecting is something not supported in rust – variadic function
I think the issue here should be handled in
datafusion-python@Michael-J-Ward Did you successfully create expression without stride=1 before 38? It would be surprising if it works previously.