cloudstack: VMware basic zone VR fails to start and get private IP

VMware basic zone does not support host-level firewall (SG), but there could be a use-case to have a basic zone setup with no isolation. Currently, the VR for the default basic zone guest network VR fails to start (gets stuck in Starting state for a long time) due to incorrect eth1 IP/netmask. Screenshot from 4.9 VR:

ISSUE TYPE

• Bug Report

COMPONENT NAME

VR, Basic Zone, VMware

CLOUDSTACK VERSION

Found in 4.9, 4.11, master

CONFIGURATION

Basic zone with VMware 5.5u3, 6.5

SUMMARY

STEPS TO REPRODUCE

- Deploy basic zone in VMware
- Deploy a guest VM
- Guest network VR will be stuck
- The /var/cache/cloud/cmdline will have 0.0.0.0 as eth1 ip/netmask

EXPECTED RESULTS

While SG does not work for VMware+basic zone, VR should start and get a private IP (eth1)

ACTUAL RESULTS

VR stuck in starting state, guest VM eventually fails to start. VR's eth1 does not get a valid IP.