arrow-rs: Rust Interval definition incorrect
It seems the Rust INTERVAL definition is incorrect. Please see https://github.com/duckdb/duckdb-wasm/issues/1696#issuecomment-2047021075 for more details on the bug and where it occurs in the code.
Particularly this definition: https://github.com/apache/arrow-rs/blob/36a6e515f99866eae5332dfc887c6cb5f8135064/arrow-array/src/types.rs#L265-L269
About this issue
- Original URL
- State: closed
- Created 3 years ago
- Comments: 15 (13 by maintainers)
Commits related to this issue
- Flip interval field ordering (#5654) — committed to tustvold/arrow-rs by tustvold 3 years ago
- Use interval type constructors in integration test (#5654) — committed to tustvold/arrow-rs by tustvold 3 years ago
- Structured interval type (#3125) (#5654) — committed to tustvold/arrow-rs by tustvold 3 years ago
- Structured interval type (#3125) (#5654) — committed to tustvold/arrow-rs by tustvold 3 years ago
- Structured interval type (#3125) (#5654) — committed to tustvold/arrow-rs by tustvold 3 years ago
- Structured interval type (#3125) (#5654) — committed to tustvold/arrow-rs by tustvold 3 years ago
- Structured interval types for `IntervalMonthDayNano` or `IntervalDayTime` (#3125) (#5654) (#5769) * Structured interval type (#3125) (#5654) * Update integration-test * Fix 32-bit build * R... — committed to apache/arrow-rs by tustvold 3 years ago
@alamb and I had a good discussion about the pros/cons of switching to a structured representation (#3125), vs simply flipping the order (#5656). The broad points were:
As such the decision was that a custom struct should be used where operations, such as arithmetic, on the integral representation have no semantic meaning. Specifically this means types such as timestamps, decimals, and even IntervalYearMonth should remain using integral types as their native representation, as operations on the integral representation are well-defined. However, types like IntervalMonthDayNano or ByteView (#5736) should switch to a non-integral representation.
We are holding the
52.0.0release for this. I expect it will be available in about 2 weeks but no promises, etcTyping down some things that @tustvold told me today: