age: Update all regression tests (label redesign)

Two big changes were made to AGE with regards to vertex\edge ID.

All vertices use the sequence ‘vertex_id_seq’ to get their IDs as ‘bigint’. Similarly, all edges use the sequence ‘edge_id_seq’ to get their IDs as ‘bigint’. Before the change, vertex\edge would generate ID from their label ID.
Both vertex and edge table have a new column: ‘label_id’::integer now.

Because of the changes, regression tests will now output new IDs, and have an extra ‘label_id’ column. Therefore, all ‘*.out’ files in the ‘/regress/expected’ folder needs to be updated.

Two diffs (before and after the change) of `cypher_create.out’ are shown below, for example:

The goal of this task is to verify that the new *.out files (changes in green) are accurate. Here, accurate means the new out files are precisely same as old ones except:

New vertex\edge ID.
Extra label_id column.

To complete this task, you need to checkout to this branch: label_redesign. Compile on PG 13.9. Produce the new *.out files for comparison.

Comment which new *.out files are accurate (justify specifically why or why not).

Note that, some tests will crash. They are not required to be worked on until the underlying issues are fixed and the ‘label_redesign’ branch is updated.

About this issue

Original URL
State: closed
Created a year ago
Comments: 25 (25 by maintainers)

Most upvoted comments

Current status of regression tests (categorized as fixed, need code changes, PR yet to merge): -

Yet to merge: - cypher_create - Yet to merge (PR#25 https://github.com/rafsun42/age/pull/25 ) cypher_merge - Yet to merge (PR#24 https://github.com/rafsun42/age/pull/24 ) age_global_graph - Yet to merge (PR#13 https://github.com/rafsun42/age/pull/13 ) index - Yet to merge (PR#19 https://github.com/rafsun42/age/pull/19 )

Need code changes: - expr - Needs code changes cypher_match - Needs code changes; Fixed other than code changes (PR#19 https://github.com/rafsun42/age/pull/19) cypher_unwind - Needs code changes cypher_set - Needs code changes cypher_remove - Needs code changes cypher_with - Needs code changes cypher_vle - Needs code changes age_load - Needs code changes graph_generation - Needs code changes

CapnSpek on Aug 14, 2023

@rafsun42 I’ll look into it and get back to it by tomorrow

CapnSpek on Jul 31, 2023

I will fix cypher_merge next. And Mohayu will be doing analyze and drop.

CapnSpek on Jul 31, 2023

Regarding cypher_with.sql / cypher_with.out: There is one test that may require some code changes.

It is test at line 87 of cypher_with.sql. Or line 130 or cypher_with.out

SELECT * FROM cypher('cypher_with', $$
    MATCH p = (m)-[*1..2]->(b) 
    WITH p, length(p) AS path_length 
    WHERE path_length > 1 
    RETURN p
$$) AS (pattern agtype);

The output is

2023-07-25 19:12:07.955 CEST [45148] ERROR:  match_vle_terminal_edge() argument 1 must be an agtype integer or a graphid
2023-07-25 19:12:07.955 CEST [45148] STATEMENT:  SELECT * FROM cypher('cypher_with', $$
	    MATCH p = (m)-[*1..2]->(b) 
	    WITH p, length(p) AS path_length 
	    WHERE path_length > 1 
	    RETURN p
	$$) AS (pattern agtype);
ERROR:  match_vle_terminal_edge() argument 1 must be an agtype integer or a graphid

CapnSpek on Jul 25, 2023