vscode-ansible: No fallback to syntax-check when ansible-lint shows invalid yaml

Problem

When I’m working on ansible roles in vscode, and I have autosave enabled after a relatively short delay (like 1 second), ansible-lint get’s triggered before I’m actually done with my change.

This results in 2 notifications: image

The error is about invalid yaml content, which is true - in that moment.

Solution

There is no need to fall back to ansible syntax-check if a usable ansible-lint is in place. Imo, a fallback should only happen if there’s either no ansible-lint, or the installed one can’t be used for whatever reason.

Instead of having 2 notifications, I’d prefer to have a more silent message, for example in the status bar telling me about broken yaml.

Alternatives

No response

Additional context

No response

About this issue

  • Original URL
  • State: closed
  • Created 2 years ago
  • Comments: 25 (5 by maintainers)

Most upvoted comments

For vscode-yaml, I think the issue is at https://github.com/redhat-developer/vscode-yaml/blob/main/Jenkinsfile#L48 . This is the only place I see the --pre-release flag used, and it only publishes a generic version on platforms that aren’t supported, but there’s nothing published for the other (supported?) platforms. If vscode-yaml doesn’t publish platform-specific code (I think that’s the case?), then there’s no need for this. You could probably remove --target win32-ia32 win32-arm64 linux-armhf alpine-x64 alpine-arm64.