angular: ngcc: packages that fail with errors causes a crash
🐞 bug report
Affected Package
The issue is caused by package @angular/compiler-cli
Is this a regression?
Yes, the previous version in which this bug was not present was: 9.0.0-rc.6
Description
When ngcc processes a package that fails to compile, a fatal error that crashes the compiler occurs.
🔬 Minimal Reproduction
For example angular-tree-component fails to compile:
https://app.circleci.com/jobs/github/angular/ngcc-validation/2459/parallel-runs/1?filterBy=ALL
🔥 Exception or Error
ERROR in Cannot read property 'injectorImports' of undefined
🌍 Your Environment
Angular Version:
Angular: 9.0.0-rc.7
Anything else relevant? n/a
About this issue
- Original URL
- State: closed
- Created 5 years ago
- Reactions: 19
- Comments: 17 (2 by maintainers)
Commits related to this issue
- fix(ngcc): do not attempt compilation when analysis fails In #34288, ngtsc was refactored to separate the result of the analysis and resolve phase for more granular incremental rebuilds. In this mode... — committed to JoostK/angular by JoostK 4 years ago
- fix(ngcc): do not attempt compilation when analysis fails In #34288, ngtsc was refactored to separate the result of the analysis and resolve phase for more granular incremental rebuilds. In this mode... — committed to JoostK/angular by JoostK 4 years ago
- fix(ngcc): do not attempt compilation when analysis fails In #34288, ngtsc was refactored to separate the result of the analysis and resolve phase for more granular incremental rebuilds. In this mode... — committed to JoostK/angular by JoostK 4 years ago
- fix(ngcc): do not attempt compilation when analysis fails In #34288, ngtsc was refactored to separate the result of the analysis and resolve phase for more granular incremental rebuilds. In this mode... — committed to JoostK/angular by JoostK 4 years ago
- fix(ngcc): do not attempt compilation when analysis fails In #34288, ngtsc was refactored to separate the result of the analysis and resolve phase for more granular incremental rebuilds. In this mode... — committed to JoostK/angular by JoostK 4 years ago
- fix(ngcc): do not attempt compilation when analysis fails (#34889) In #34288, ngtsc was refactored to separate the result of the analysis and resolve phase for more granular incremental rebuilds. In ... — committed to angular/angular by JoostK 4 years ago
- fix(ngcc): do not attempt compilation when analysis fails (#34889) In #34288, ngtsc was refactored to separate the result of the analysis and resolve phase for more granular incremental rebuilds. In ... — committed to sonukapoor/angular by JoostK 4 years ago
@vokeit-gschuster The bug itself has not been fixed, the fix PR is still pending. However, it may be that a bug which was causing the library to fail compiling has been fixed, in which case you won’t observe the bug anymore.
+1
The same error when running
ngcc --properties es2015 browser module main --first-only --create-ivy-entry-pointsFirst execution error, second execution is correct