angular: Missing metadata for @angular/common/locales
I’m submitting a…
[ ] Regression (a behavior that used to work and stopped working in a new release)
[x] Bug report
[ ] Feature request
[ ] Documentation issue or request
[ ] Support request => Please do not submit support request here, instead see https://github.com/angular/angular/blob/master/CONTRIBUTING.md#question
Current behavior
The content of every [locale].metadata.json file is [null]. This seems to break the angular vscode language service, and is probably not intended.
Expected behavior
Some actual metadata perhaps? I’m not sure what the contents of these files are supposed to be, but it seems like most libraries have objects top-level in the metadata files.
Minimal reproduction of the problem with instructions
https://github.com/angular/common-builds/blob/master/locales/en-GB.metadata.json
Environment
Angular version: 5.0.0+
Browser: N/A
For Tooling issues: N/AAbout this issue
- Original URL
- State: closed
- Created 7 years ago
- Reactions: 14
- Comments: 24 (13 by maintainers)
Commits related to this issue
- fix(language-service): ignore null metadatas There can be null metadatas in certain cases, for example with locales. Fixes #20260 — committed to victornoel/angular by victornoel 7 years ago
- fix(language-service): ignore null metadatas There can be null metadatas in certain cases, for example with locales. Fixes #20260 — committed to victornoel/angular by victornoel 7 years ago
- fix(language-service): ignore null metadatas (#20557) There can be null metadatas in certain cases, for example with locales. Fixes #20260 PR Close #20557 — committed to angular/angular by victornoel 7 years ago
- fix(language-service): ignore null metadatas (#20557) There can be null metadatas in certain cases, for example with locales. Fixes #20260 PR Close #20557 — committed to angular/angular by victornoel 7 years ago
- fix(language-service): ignore null metadatas (#20557) There can be null metadatas in certain cases, for example with locales. Fixes #20260 PR Close #20557 — committed to leo6104/angular by victornoel 7 years ago
Fixed with #20938
@vicb any way to get this fixed? There has been two patch releases since this issue was reported and I suppose this could be fixed simply, no? If you have a recommendation on how to do that, I can do a PR 😃
Same issue. I think the problem occurs because the Angular Language Service extension uses
@angular/language-service@5.0.0-beta.5. the extension needs to be updated to use@angular/language-service@5.0.1I have the same issue angular 5.0.0. and VSCode 1.17.2 Replacing
[null]with[]in the[locale].metadata.jsonfile innode_modulesseems to solve it; so far everything seems to work. Modifying files innode_modulesis far from ideal, but at least VS Code is working until a more permanent solution.