Hey guys, I still have a problem with the “equiv-text” attribute. I am using the latest tag 10.1.6 from the CLI but some translation messages still have incorrect values.

eg.: <ng-container i18n="Update @@update"> <b>{{value1}}:</b> current {{value2}} to new {{value3}} </ng-container>

will be extracted as (with --ivy):

        <source>
                <x id="START_BOLD_TEXT" equiv-text="  &lt;b&gt;{{value1"/>
                <x id="INTERPOLATION" equiv-text="b&gt;{{value1"/>:
                <x id="CLOSE_BOLD_TEXT" equiv-text="}:&lt;/b&gt;"/>
                 current <x id="INTERPOLATION_1" equiv-text="t {{value2"/> 
                 to new <x id="INTERPOLATION_2" equiv-text=" to new {{"/>
       </source>

will be extracted as (without --ivy):

        <source>
                <x id="START_BOLD_TEXT" ctype="x-b" equiv-text="&lt;b&gt;"/>
                <x id="INTERPOLATION" equiv-text="{{value1}}"/>: 
                <x id="CLOSE_BOLD_TEXT" ctype="x-b" equiv-text="&lt;/b&gt;"/>
                current <x id="INTERPOLATION_1" equiv-text="{{value2}}"/>
                to new <x id="INTERPOLATION_2" equiv-text="{{value3}}"/>
        </source>

Is this an issue in my code or in the cli extraction command?

Example Repo https://github.com/Niklas187/ng-xi18n-ivy-bug.git

version:

Angular CLI: 10.1.6 Node: 12.16.0 OS: win32 x64

Angular: 10.1.3 … animations, common, compiler, core, forms, localize … platform-browser, platform-browser-dynamic, router Ivy Workspace: Yes

Package Version

@angular-devkit/architect 0.1001.6 @angular-devkit/build-angular 0.1001.6 @angular-devkit/core 10.1.6 @angular-devkit/schematics 10.1.6 @angular/cli 10.1.6 @angular/compiler-cli 10.1.5 @schematics/angular 10.1.6 @schematics/update 0.1001.6 rxjs 6.6.3 typescript 4.0.3

OK, I worked out what is going on. The localize stuff relies upon a FileSystem, which the CLI is mocking up to get everything to work. But… internally the extraction is calling absoluteFrom(), which looks for a “current” FileSystem by calling getFileSystem(). This is a kind of global that should be set via setFileSystem() before running the localize code.

But CLI is not calling this and so the “current” FileSystem is different to the one being passed in and it is converting backslashes to forward slashes in paths. So the source-maps are not being loaded from the fake file system that the CLI is providing.

Arguably the CLI shouldn’t have to worry about the “current” FileSystem. I’ll look into the best way to fix this…

OK, so it is something to do with the CLI integration… on Windows I get the same problem if I use ng xi18n. But try the following:

node_modules\.bin\ngc -p tsconfig.app.json
node_modules\.bin\localize-extract -s out-tsc\**\*.js -f xlf2 -o src\locale\messages.xlf

This generates the correct output.

Tested locally and #38645 does appear to fix this issue. Running the commands on the above reproduction results in:

<?xml version="1.0" encoding="UTF-8" ?>
<xliff version="2.0" xmlns="urn:oasis:names:tc:xliff:document:2.0" srcLang="en-US">
  <file id="ngi18n" original="ng.template">
    <unit id="5078016957909331967">
      <segment>
        <source>My name is <ph id="0" equiv="INTERPOLATION" disp="{{name}}"/></source>
      </segment>
    </unit>
  </file>
</xliff>

This might be fixed by https://github.com/angular/angular/pull/38645 I will test later today

Yes this is a different issue

On Fri, Sep 4, 2020 at 05:22 Sonu Kapoor notifications@github.com wrote:

Hi, @jaska45 https://github.com/jaska45 Is this different from the other issue you posted #38711 https://github.com/angular/angular/issues/38711?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/angular/angular/issues/38711#issuecomment-687109794, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACM7TWF5K64MEYQNUEDJRXDSEDL2BANCNFSM4QYDAITQ .