angular-cli: ng add @angular/pwa doesn't work correctly in angular-cli 6.2.5 (Maximum call stack size exceeded)
Bug Report or Feature Request (mark with an x)
- [x] bug report -> please search issues before submitting
- [ ] feature request
Command (mark with an x)
- [ ] new
- [ ] build
- [ ] serve
- [ ] test
- [ ] e2e
- [ ] generate
- [x] add
- [ ] update
- [ ] lint
- [ ] xi18n
- [ ] run
- [ ] config
- [ ] help
- [ ] version
- [ ] doc
Versions
Angular CLI: 6.2.5 Node: 8.11.3 OS: win32 x64 Angular: 6.1.10 … animations, common, compiler, compiler-cli, core, forms … http, language-service, platform-browser … platform-browser-dynamic, router
Package Version
@angular-devkit/architect 0.8.5 @angular-devkit/build-angular 0.8.5 @angular-devkit/build-optimizer 0.8.5 @angular-devkit/build-webpack 0.8.5 @angular-devkit/core 0.8.5 @angular-devkit/schematics 0.8.5 @angular/cdk 6.4.7 @angular/cli 6.2.5 @angular/material 6.4.7 @angular/pwa 0.10.5 @ngtools/webpack 6.2.5 @schematics/angular 0.8.5 @schematics/update 0.8.5 rxjs 6.2.2 typescript 2.9.2 webpack 4.20.2
Repro steps
ng new pwademo ng add @angular/material ng build --prod ng add @angular/pwa
The log given by the failure
Installing packages for tooling via npm. npm WARN optional SKIPPING OPTIONAL DEPENDENCY: fsevents@1.2.4 (node_modules\fsevents): npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for fsevents@1.2.4: wanted {“os”:“darwin”,“arch”:“any”} (current: {“os”:“win32”,“arch”:“x64”})
- @angular/pwa@0.10.5 updated 1 package in 47.645s Installed packages for tooling via npm. Maximum call stack size exceeded
Desired functionality
The command doesnt add automatically PWA features to my Angular application such as manifest file or icons in assets folder or edit my index.html file with reference to manifest, only show me the error message Maximum call stack size exceeded
Mention any other details that might be useful
About this issue
- Original URL
- State: closed
- Created 6 years ago
- Reactions: 12
- Comments: 25 (7 by maintainers)
Commits related to this issue
- docs: Add LTS version to PWA install As suggested by @clydin in https://github.com/angular/angular-cli/issues/12914 — committed to adamkasztenny/angular by adamkasztenny 6 years ago
- Instalado Angular PWA usando la versión v6-lts (https://github.com/angular/angular-cli/issues/12914#issuecomment-437486393) — committed to TrainingITCourses/final-jagomf by jagomf 6 years ago
- fix(@angular/cli): 'ng add' selects supported version via peer dependencies If no version specifier is supplied `ng add` will now try to find the most recent version of the package that has peer depe... — committed to clydin/angular-cli by clydin 6 years ago
- fix(@angular/cli): 'ng add' selects supported version via peer dependencies If no version specifier is supplied `ng add` will now try to find the most recent version of the package that has peer depe... — committed to clydin/angular-cli by clydin 6 years ago
- fix(@angular/cli): 'ng add' selects supported version via peer dependencies If no version specifier is supplied `ng add` will now try to find the most recent version of the package that has peer depe... — committed to angular/angular-cli by clydin 6 years ago
Currently you will need to execute
ng add @angular/pwa@v6-ltsto ensure the version compatible with Angular 6 is used.I’m having the same issue. I was able to get it to work by specifying the previous stable release:
ng add @angular/pwa@0.8.7 --project my-project-nameHi, the problem is no longer reproducable if you use the latest versions of the CLI and devkit packages.
No issue with bellow version. Update your cli.
ng versionAngular CLI: 7.0.5 Node: 10.11.0 Angular: 7.0.3
“@angular-devkit/build-angular”: “^0.10.5”, “@angular/cli”: “^7.0.5”, This worked for me also (in project package.json)
The latest version is targeted to be used with Version 7.
@jakawell muchas gracias. Me funciono (y)
For my case I updated my angular CLI and then ‘ng add @angular/pwa’ is working fine. To update Angular CLI in your project use:
npm uninstall --save-dev angular-cli npm install --save-dev @angular/cli@latest
The root cause here is that the @angular/pwa doesn’t declare any peerDependency in the package.json config, so the npm client installs the latest one which doesn’t seem to be compatible. To fix this we need to define a peerDep on the right version.
To fix this for v6 developers, we might need to cut a version that is compatible with v6 and declares a peerDep on v6.
@jakawell thanks so much.You rock.
I am using nx extensions cli v7 and angular cli 7.0.5 and ran into the same issue. @jakawell thanks for your solution , that one works (using the older version/stable version of @angular/pwa@0.8.7)
Oh hell, it worked for me. But is there any clue as to why? Thanks @jakawell.