angular-cli: Lazy loaded styles are never hashed
We are great fans of lazy-css functionality in ng build
, it allows us to serve several apps from one code-base, as we add app1.css … appN.css depending on the request, using angular universal.
Given our high-traffic page we use a CDN and therefore rely on changing hashes for changed CSS, as we otherwise would have to manage CSS cache invalidation manually.
How can we have hashed lazy CSS back?
Bug Report or Feature Request (mark with an x
)
- [x] bug report -> please search issues before submitting
- [ ] feature request
Command (mark with an x
)
- [x] build
Versions
$ node --version
v8.11.4
$ npm --version
5.10.0
$ ng --version
_ _ ____ _ ___
/ \ _ __ __ _ _ _| | __ _ _ __ / ___| | |_ _|
/ △ \ | '_ \ / _` | | | | |/ _` | '__| | | | | | |
/ ___ \| | | | (_| | |_| | | (_| | | | |___| |___ | |
/_/ \_\_| |_|\__, |\__,_|_|\__,_|_| \____|_____|___|
|___/
Angular CLI: 6.2.4
Node: 8.11.4
OS: darwin x64
Angular: 6.1.2
... animations, common, compiler, compiler-cli, core, http
... platform-browser, platform-browser-dynamic, platform-server
... router, service-worker
Package Version
------------------------------------------------------------
@angular-devkit/architect 0.0.0
@angular-devkit/architect-cli 0.0.0
@angular-devkit/build-angular 0.0.0
@angular-devkit/build-ng-packagr 0.0.0
@angular-devkit/build-optimizer 0.0.0
@angular-devkit/build-webpack 0.0.0
@angular-devkit/core 0.0.0
@angular-devkit/schematics 0.0.0
@angular-devkit/schematics-cli 0.0.0
@angular/cdk 6.4.5
@angular/cli 0.0.0
@angular/material 6.4.5
@angular/pwa 0.0.0
@ngtools/json-schema 1.1.0
@ngtools/webpack 0.0.0
@schematics/angular 0.0.0
@schematics/schematics 0.0.0
@schematics/update 0.0.0
ng-packagr 4.1.0
rxjs 6.2.2
typescript 2.9.2
webpack 4.16.4
MacOS 10.14 Mojave
Repro steps
my-app/angular.json
-> projects/my-apparchitect/build
:
{
"input": "src/extra.css",
"lazy": true,
"bundleName": "extra"
}
Then run:
$ ng build --prod
Example in: https://github.com/maosmurf/ng-demo/tree/lazy-styles
The log given by the failure
chunk {4} extra.css (extra) 0 bytes [initial] [rendered]
Desired functionality
extra.123456678.css
instead of extra.css
, as it was until recently.
While removing the hash from lazy styles helps with lazy includes, it hinders cache invalidation.
Our use-case:
We render the app (kurier.at) and have lazy styles. Given we use angular universal, we have no problem checking /dist
for the current css hash file.
After deploying a new version, the new css (with changed hash) is included, yet the old CSS remains valid on CDN (cloudflare) - so there are 2 benefits fron this:
- no need for invalidating style.css
- old CSS remains valid for old cached pages.
How can we get the old functionality back? Currently, our only option for upgrading to ng6 would be to manually add hashes after ng build --prod
About this issue
- Original URL
- State: closed
- Created 6 years ago
- Reactions: 30
- Comments: 20 (6 by maintainers)
This is intentional, lazy loaded styles are not referenced by the built application automatically and are only intended to be referenced by the developer. As such, a hash prevents the file from being deterministically referenced as the name would change upon every content change.
In addition, since the file is not referenced automatically within the application, the filename can be modified as necessary after the build. So as mentioned, if the project wanted a hash or some other unique identifier attached, it could do so with a post build step.
There is the potential for an additional capability in regards to either allowing template tags in
bundleName
or adding an additional option to enable hashing on a per file basis. I’m going to mark this as a feature request.Thank you for the feedback.
I fully understand the motivation for the recent changes, yet the backwards-incompatible changes caused some headache.
Done.
Would be great to have old functionality back using already provided tools (without the need of manual post-build step), so thank you for that 👍
The Angular material themes ideally should not be used within component styles. They are recommended to be placed in a global stylesheet via the project’s
styles
option or directly in the index.html via alink
element as a project asset. For additional information, please see https://material.angular.io/guide/theming#using-a-pre-built-theme One of the added benefits of using a global style is that Angular 11 also provides the newinlineCritical
style optimization which will analyze all global styles, inline critical CSS within the HTML and then lazy load the remainder of the global styles.