angular-cli: Error loading npm linked custom library with aot
Please provide us with the following information:
OS?
Windows 7, 8 or 10. Linux (which distribution). Mac OSX (Yosemite? El Capitan?)
Mac OSX, El Capitan
Versions.
Please run
ng --version
. If there’s nothing outputted, please run in a Terminal:node --version
and paste the result here:
angular-cli: 1.0.0-beta.24
node: 6.9.2
os: darwin x64
@angular/common: 2.4.1
@angular/compiler: 2.4.1
@angular/core: 2.4.1
@angular/forms: 2.4.1
@angular/http: 2.4.1
@angular/platform-browser: 2.4.1
@angular/platform-browser-dynamic: 2.4.1
@angular/router: 3.4.1
@angular/compiler-cli: 2.4.1
Repro steps.
Was this an app that wasn’t created using the CLI? What change did you do on your code? etc.
From a really fresh angular cli project.
Only adding in app.module.ts :
import { MessageModule } from 'my_lib';
@NgModule({
declarations: [
AppComponent
],
imports: [
BrowserModule,
FormsModule,
HttpModule,
MessageModule.forRoot() // <-- include here
],
providers: [],
bootstrap: [AppComponent]
})
export class AppModule { }
Adding one of the component in app.component.html
<my-message type="error">This is an error message</my-message>
And running
ng build --aot
The log given by the failure.
Normally this include a stack trace and some more information.
chunk {0} main.bundle.js, main.bundle.map (main) 1.48 kB {2} [initial] [rendered]
chunk {1} styles.bundle.css, styles.bundle.map, styles.bundle.map (styles) 1.77 kB {3} [initial] [rendered]
chunk {2} vendor.bundle.js, vendor.bundle.map (vendor) 1.06 MB [initial] [rendered]
chunk {3} inline.bundle.js, inline.bundle.map (inline) 0 bytes [entry] [rendered]
ERROR in Error encountered resolving symbol values statically. Calling function 'makeDecorator', function calls are not supported. Consider replacing the function or lambda with a reference to an exported function, resolving symbol Injectable in /Users/admin/dev/web-library/node_modules/@angular/core/src/di/metadata.d.ts, resolving symbol OpaqueToken in /Users/admin/dev/web-library/node_modules/@angular/core/src/di/opaque_token.d.ts, resolving symbol OpaqueToken in /Users/admin/dev/web-library/node_modules/@angular/core/src/di/opaque_token.d.ts
ERROR in ./src/main.ts
Module not found: Error: Can't resolve './$$_gendir/app/app.module.ngfactory' in '/Users/admin/dev/web-library/ng24/src'
@ ./src/main.ts 4:0-74
@ multi main
ERROR in ./~/@angular/core/src/linker/system_js_ng_module_factory_loader.js
Module not found: Error: Can't resolve '/Users/admin/dev/web-library/ng24/src/$$_gendir' in '/Users/admin/dev/web-library/ng24/node_modules/@angular/core/src/linker'
@ ./~/@angular/core/src/linker/system_js_ng_module_factory_loader.js 69:15-36 85:15-102
@ ./~/@angular/core/src/linker.js
@ ./~/@angular/core/src/core.js
@ ./~/@angular/core/index.js
@ ./src/main.ts
@ multi main
Mention any other details that might be useful.
My message module declare and exports the message component, with inlined css/html.
It’s Exported with a forRoot :
export class MessageModule {
public static forRoot(): ModuleWithProviders {
return {ngModule: MessageModule, providers: []};
}
}
my_lib is generated with ngc, with a .metadata.json near each d.ts. With following tsconfig parameters :
...
"target": "es5",
"module": "es2015",
...
"angularCompilerOptions": {
"skipTemplateCodegen": true
}
Thanks! We’ll be in touch soon.
About this issue
- Original URL
- State: closed
- Created 7 years ago
- Reactions: 18
- Comments: 31 (4 by maintainers)
It seems like this is a issue caused by Typescript and not by Angular CLI. Typescript has problems resolving dependencies when
yarn link
ornpm link
is used, as you can see here #11916 and here #6496. This problem could be solved with Typescript 2.1 (read more here).For now, thanks to this post #1858 I found a good workaround, which doesn’t affect the actual code of the library, as it is the case with an empty
.forRoot()
. Furthermore, you don’t have to deletenode_modules
anymore. Just add apaths
property with all angular dependencies to the tsconfig file of the Angular CLI project, where you include your library withyarn link
ornpm link
.Here is my full tsconfig.json:
@SebastianSchenk perhaps worth noting: Your solution (which resolved this issue for me - a million thanks) can be rewritten as:
paths: { "@angular/*": ["../node_modules/@angular/*"] }
This paths: { “@angular/“: [”…/node_modules/@angular/”] } workaround didn’t work for me. Please help 😦
@jppellerin I had the same issue, removing
node_modules
from the feature module fixed it. Thanks for sharing! 👍@SebastianSchenk I was having a very similar issue with a feature module I am building under it’s own dependency. With you’re hypothesis, I removed my
node_modules
directory from my feature module before linking it. After that, everything worked like a charm.I’m getting a bunch of errors in my feature module since none of it’s dependencies are present… but that more or less add to an issue with duplication in the
node_modules
folder.I have the same problem getting this error. This error is thrown when I try to import a module coming outside my angular-cli root. E.g. import {TestModule} from ‘…/…/…/…<angular-cli root>/…/…/Private/test-share/src/app/test/test.module’;
Doesn’t matter if I use the source .ts file or the compiled version. Also happens when linking with yarn link.
Hi,
Anybody is albe to explain what is the real cause? I have added that path mapping and it resolves my problem. But I think this is not really a solution as more workaround.
When I create new project using ng new XXXX, simulate identical setup All is fine and I dont have a issue. just for my existing project.
@msusur thank your for the example. Using .forRoot helps as a workaround to avoid the error. However, it also helped me to find the root of the problem. I just cloned the lib from github and linked it with
yarn link
to my project. After that, I imported the module and added it to the imports array of my AppModule without using .forRoot. Everything worked, no errors. After installing the dependencies of the lib, the error was thrown. Now I had to use .forRoot to make to error disappear.To sum it up. The error occurs only when the lib also contains node_modules. I think it has something to do with @angular/* being a in both node_modules.
I edited the title and added the FAQ label to make it easier for people having the same problem to find this.
So maybe it’s a VS Code thing or npm thing, I don’t know, but somehow the file paths to our symlink’ed modules had their direct paths added (…/…/…/patient/node_modules/*). We spent quite awhile trying to hunt down this issue, and apparently an automated process re-wrote the file paths in app.module.ts.
SHOULD BE:
OVERWRITTEN FILE PATHS:
I’ve encountered this error when having a dependency installed from the local file directory. NPM5 creates a symlink which doesn’t seem to want to play nice with the AOT compiler. I solved it by downgrading to NPM3 with
npm install -g npm@3
which will by default install the dependency simulating an install from NPM, and use the package.json and .npmignore files. Alternatively, you may want to try something like the npm package npm install-local https://www.npmjs.com/package/install-local.Hopefully, this helps someone else down the road.