angular: Bazel build of router broken in 6.0.5

This commit https://github.com/angular/angular/commit/d20877bf3fec3b6475c7ebba440366101b272549#diff-c68ccdefc54b5e3375135dddaa34d46c causes ngc to produce a summary file

{"__symbol":110,"name":"ɵEmptyOutletComponent","filePath":"./router"},
{"__symbol":111,"name":"ApplicationRef","filePath":"@angular/core"},
{"__symbol":112,"name":"SystemJsNgModuleLoader","filePath":"@angular/core"},
{"__symbol":113,"name":"ɵflatten","filePath":"./router"},
{"__symbol":114,"name":"ɵEmptyOutletComponentNgFactory","filePath":"./router.ngfactory"},
{"__symbol":115,"name":"View_ɵEmptyOutletComponent_0","filePath":"./router.ngfactory"},
{"__symbol":116,"name":"RenderType_ɵEmptyOutletComponent","filePath":"./router.ngfactory"}]}

to point to a ngfactory in a way that breaks the compile: https://github.com/alexeagle/angular-bazel-example/pull/154

ERROR: /home/circleci/ng/src/hello-world/BUILD.bazel:13:1: Compiling Angular templates (ngc) //src/hello-world:hello-world failed (Exit 1)

: Error: Could not resolve ./router.ngfactory from /home/circleci/.cache/bazel/_bazel_circleci/9ce5c2144ecf75d11717c0aa41e45a8d/execroot/angular_bazel_example/node_modules/@angular/router/router.d.ts
    at TsCompilerAotCompilerTypeCheckHostAdapter.fromSummaryFileName (/home/packages/compiler-cli/src/transformers/compiler_host.ts:274:13)
    at AotSummaryResolver.fromSummaryFileName (/execroot/angular/packages/compiler/src/aot/summary_resolver.ts:64:22)
    at /execroot/angular/packages/compiler/src/aot/summary_serializer.ts:441:34
    at Array.map (<anonymous>)
    at FromJsonDeserializer.deserialize (/execroot/angular/packages/compiler/src/aot/summary_serializer.ts:439:33)
    at deserializeSummaries (/execroot/angular/packages/compiler/src/aot/summary_serializer.ts:61:23)
    at AotSummaryResolver._loadSummaryFile (/execroot/angular/packages/compiler/src/aot/summary_resolver.ts:118:13)
    at AotSummaryResolver.resolveSummary (/execroot/angular/packages/compiler/src/aot/summary_resolver.ts:73:12)
    at StaticSymbolResolver._resolveSymbolFromSummary (/execroot/angular/packages/compiler/src/aot/static_symbol_resolver.ts:234:42)
    at StaticSymbolResolver.resolveSymbol (/execroot/angular/packages/compiler/src/aot/static_symbol_resolver.ts:85:36)

About this issue

  • Original URL
  • State: closed
  • Created 6 years ago
  • Reactions: 3
  • Comments: 24 (21 by maintainers)

Most upvoted comments

@gregmagolan will take a look at making Angular source dependency work in angular-bazel-example, which would give us a principled way to avoid these issues.