angular: Angular 6 Animation is not working in IE
I’m submitting a…
[ ] Regression (a behavior that used to work and stopped working in a new release)
[x ] Bug report
[ ] Performance issue
[ ] Feature request
[ ] Documentation issue or request
[ ] Support request => Please do not submit support request here, instead see https://github.com/angular/angular/blob/master/CONTRIBUTING.md#question
[ ] Other... Please describe:
Current behavior
I have the following animation in Angular 6.
slide-in-out-animation.ts
// import the required animation functions from the angular animations module
import { trigger, state, animate, transition, style } from '@angular/animations';
export const slideInOutAnimation =
// trigger name for attaching this animation to an element using the [@triggerName] syntax
trigger('slideInOutAnimation', [
// end state styles for route container (host)
state('*', style({
// the view covers the whole screen with a semi tranparent background
position: 'fixed',
zIndex: 6,
top: 0,
left: 0,
right: 0,
bottom: 0,
backgroundColor: 'rgba(0, 0, 0, 0.8)'
})),
// route 'enter' transition
transition(':enter', [
// styles at start of transition
style({
// start with the content positioned off the right of the screen,
// -400% is required instead of -100% because the negative position adds to the width of the element
right: '-400%',
zIndex: 6,
// start with background opacity set to 0 (invisible)
backgroundColor: 'rgba(0, 0, 0, 0)'
}),
// animation and styles at end of transition
animate('.5s ease-in-out', style({
// transition the right position to 0 which slides the content into view
right: 0,
zIndex: 6,
// transition the background opacity to 0.8 to fade it in
backgroundColor: 'rgba(0, 0, 0, 0.8)'
}))
]),
// route 'leave' transition
transition(':leave', [
// animation and styles at end of transition
animate('.5s ease-in-out', style({
zIndex:6,
// transition the right position to -400% which slides the content out of view
right: '-400%',
// transition the background opacity to 0 to fade it out
backgroundColor: 'rgba(0, 0, 0, 0)'
}))
])
]);
When I want to use the animation in a Component:
@Component({
selector: 'app-example-edit',
templateUrl: './example-edit.component.html',
styleUrls: ['./example-edit.component.css'],
// make slide in/out animation available to this component
animations: [slideInOutAnimation],
// attach the slide in/out animation to the host (root) element of this component
host: { '[@slideInOutAnimation]': '' }
})
export class ExampleComponent {
}
In parent-component.html I have the html
<a href="#" routerLink="add">Add</a>
<div class="view-side-form">
<router-outlet></router-outlet>
</div>
In the parentcomponent I have a link to add a element. When the user click in the link. The content of examplecomponent is loaded using the animation. In chrome is working perfect. But in Internet Explorer the animation is not working. Also, the animation is working perfect using Angular5 in Chrome and IE. The problem is when i want to use it with Angular 6.
This is my package.json file
{
"name": "app-web",
"version": "0.0.0",
"scripts": {
"ng": "ng",
"start": "ng serve",
"build": "ng build",
"test": "ng test",
"lint": "ng lint",
"e2e": "ng e2e"
},
"private": true,
"dependencies": {
"@angular/animations": "^6.0.3",
"@angular/cdk": "^6.3.3",
"@angular/common": "^6.0.3",
"@angular/compiler": "^6.0.3",
"@angular/core": "^6.0.3",
"@angular/forms": "^6.0.3",
"@angular/http": "^6.0.3",
"@angular/material": "^6.3.3",
"@angular/platform-browser": "^6.0.3",
"@angular/platform-browser-dynamic": "^6.0.3",
"@angular/router": "^6.0.3",
"@types/jquery": "^3.3.4",
"angular2-moment": "^1.9.0",
"angular2-multiselect-dropdown": "^2.9.0",
"angular2-toaster": "^6.1.0",
"bootstrap": "^3.3.7",
"chart.js": "^2.7.2",
"core-js": "^2.5.4",
"font-awesome": "^4.7.0",
"jquery": "^3.3.1",
"ng2-bs3-modal": "^0.15.0",
"ng2-charts": "^1.6.0",
"ng2-datetime": "^1.4.0",
"ngx-bootstrap": "^3.0.1",
"rxjs": "^6.0.0",
"web-animations-js": "^2.3.1",
"zone.js": "^0.8.26"
},
"devDependencies": {
"@angular/compiler-cli": "^6.0.3",
"@angular-devkit/build-angular": "~0.6.8",
"typescript": "~2.7.2",
"@angular/cli": "~6.0.8",
"@angular/language-service": "^6.0.3",
"@types/jasmine": "~2.8.6",
"@types/jasminewd2": "~2.0.3",
"@types/node": "~8.9.4",
"codelyzer": "~4.2.1",
"jasmine-core": "~2.99.1",
"jasmine-spec-reporter": "~4.2.1",
"karma": "~1.7.1",
"karma-chrome-launcher": "~2.2.0",
"karma-coverage-istanbul-reporter": "~2.0.0",
"karma-jasmine": "~1.1.1",
"karma-jasmine-html-reporter": "^0.2.2",
"protractor": "~5.3.0",
"ts-node": "~5.0.1",
"tslint": "~5.9.1"
}
}
polyfills.ts
/** IE9, IE10 and IE11 requires all of the following polyfills. **/
import 'core-js/es6/symbol';
import 'core-js/es6/object';
import 'core-js/es6/function';
import 'core-js/es6/parse-int';
import 'core-js/es6/parse-float';
import 'core-js/es6/number';
import 'core-js/es6/math';
import 'core-js/es6/string';
import 'core-js/es6/date';
import 'core-js/es6/array';
import 'core-js/es6/regexp';
import 'core-js/es6/map';
import 'core-js/es6/weak-map';
import 'core-js/es6/set';
/** IE10 and IE11 requires the following for NgClass support on SVG elements */
// import 'classlist.js'; // Run `npm install --save classlist.js`.
/** IE10 and IE11 requires the following for the Reflect API. */
// import 'core-js/es6/reflect';
/** Evergreen browsers require these. **/
// Used for reflect-metadata in JIT. If you use AOT (and only Angular decorators), you can remove.
import 'core-js/es7/reflect';
/**
* Web Animations `@angular/platform-browser/animations`
* Only required if AnimationBuilder is used within the application and using IE/Edge or Safari.
* Standard animation support in Angular DOES NOT require any polyfills (as of Angular 6.0).
**/
import 'web-animations-js'; // Run `npm install --save web-animations-js`.
/**
* By default, zone.js will patch all possible macroTask and DomEvents
* user can disable parts of macroTask/DomEvents patch by setting following flags
*/
// (window as any).__Zone_disable_requestAnimationFrame = true; // disable patch requestAnimationFrame
// (window as any).__Zone_disable_on_property = true; // disable patch onProperty such as onclick
// (window as any).__zone_symbol__BLACK_LISTED_EVENTS = ['scroll', 'mousemove']; // disable patch specified eventNames
/*
* in IE/Edge developer tools, the addEventListener will also be wrapped by zone.js
* with the following flag, it will bypass `zone.js` patch for IE/Edge
*/
// (window as any).__Zone_enable_cross_context_check = true;
/***************************************************************************************************
* Zone JS is required by default for Angular itself.
*/
import 'zone.js/dist/zone'; // Included with Angular CLI.
In Angular5 is working perfect in all browsers, but when I want to migrate to Angular6 i have problems with IE. No errors in IE console.
Minimal reproduction of the problem with instructions
You can reproduce the problem in the following link: https://stackblitz.com/edit/angular-grryts
About this issue
- Original URL
- State: closed
- Created 6 years ago
- Reactions: 7
- Comments: 18 (4 by maintainers)
Links to this issue
Commits related to this issue
- fix(animations): ensure `position` and `display` styles are handled outside of keyframes/web-animations When web-animations and/or CSS keyframes are used for animations certain CSS style values (such... — committed to matsko/angular by matsko 5 years ago
- fix(animations): ensure `position` and `display` styles are handled outside of keyframes/web-animations When web-animations and/or CSS keyframes are used for animations certain CSS style values (such... — committed to matsko/angular by matsko 5 years ago
- fix(animations): ensure `position` and `display` styles are handled outside of keyframes/web-animations When web-animations and/or CSS keyframes are used for animations certain CSS style values (such... — committed to matsko/angular by matsko 5 years ago
- fix(animations): ensure `position` and `display` styles are handled outside of keyframes/web-animations When web-animations and/or CSS keyframes are used for animations certain CSS style values (such... — committed to matsko/angular by matsko 5 years ago
- fix(animations): ensure `position` and `display` styles are handled outside of keyframes/web-animations When web-animations and/or CSS keyframes are used for animations certain CSS style values (such... — committed to matsko/angular by matsko 5 years ago
- fix(animations): ensure `position` and `display` styles are handled outside of keyframes/web-animations When web-animations and/or CSS keyframes are used for animations certain CSS style values (such... — committed to matsko/angular by matsko 5 years ago
- fix(animations): ensure `position` and `display` styles are handled outside of keyframes/web-animations (#28911) When web-animations and/or CSS keyframes are used for animations certain CSS style val... — committed to angular/angular by matsko 5 years ago
There is also a problem in IE that
ng-component
s aren’t removed when routing animation is done. Thus, allng-componet
s stay in the DOM even if we left the route. Not sure if a separate ticket should be created for that.@jackmusick After what feels like a lifetime of debugging, I know what was causing this for me so maybe it will help you.
I have dynamic components in my template that I don’t want to be removed from the DOM while the page is being navigated away from (it looks weird). In order to prevent them from being hidden, I added a block to my animation that look like this:
query(':leave ng-component', [animate('1.5s')], {optional: true})
This worked in all browsers besides IE. So I dug into the code. Because IE requires polyfilling, it uses CssKeyFrames instead of WebAnimations. CssKeyFrames generates CSS for my code that looks like this:
Angular is relying on the animationend event to remove elements from the DOM. IE never triggers the animation end event when there are no animatable properties in the block (for instance: display block -> display block also does not trigger the animationend event).
Until Angular puts in a fix, I have resolved this by adding animatable properties to my ng-component query:
@opetriienko Is there an issue open for this? I can’t find one and am experiencing the same.
@jackmusick I’m not using the CLI, either. My understanding is that the CLI is supposed to take care of setting up the Webpack config correctly, though. If the Angular team considers disabling Webpack’s node process option to be the correct solution, then I would expect the CLI to do this out-of-the-box.
I was able to fix the “Object doesn’t support property or method ‘matches’” error in Internet Explorer by setting
node: {process: false}
in my Webpack config. See https://github.com/angular/angular/issues/24769#issuecomment-405498008.This was a surprise for me to upgrade from angular 4 with purposely no animation polyfill to angular 6.
I did not include it because it was not rendering well on IE., but now that the polyfill is not needed, my app on IE is a disaster with broken animation and components not being destroyed.
This is an important regression.