engine-sim: Missing engine

The video shows CHEV 454 V8 but I can only find Kohler CH750 in the source code? Has it been intentionally removed? If yes, could you give a hint on how to obtain an engine similar to that in the video, I tried editing the assets/kohler_ch750.mr file but sadly it does not work as intended. (I neither know C++ nor piranha).

I tried adding two more wires, a crankshaft, another exhaust and 2 more cylinder banks and then tried to bind it to the engine (class/enum/dictionary?) from what I could make out of the language but now it just won’t open.

Thanks for this mind blowing project.

About this issue

Original URL
State: closed
Created 2 years ago
Reactions: 5
Comments: 20 (2 by maintainers)

Most upvoted comments

Okay glad we both have the issue. I’m new to all of this GitHub etc, so if the simulator was to be improved, is it only Ange who can do that? Like adding a terminal to change cylinder count etc. I.e do we just have to be patient or can we contribute as well?

anyone can help out and modify open sourced code on github all they want via a fork, if they feel like the code should be on the main repo they can pull-request their changes on the main repo, and if the owner approves it, it will get merged to the main repo

in this case main repo is /ange-yaghi/engine-sim a fork would look like /Chalcedonity/engine-sim

BoogieHasFun on Aug 10, 2022

We can contribute as well by forking the repository and making a pull request, like the one that updated the readme.

Hacker1245 on Aug 10, 2022

Okay glad we both have the issue. I’m new to all of this GitHub etc, so if the simulator was to be improved, is it only Ange who can do that? Like adding a terminal to change cylinder count etc. I.e do we just have to be patient or can we contribute as well?

Technically no, but yes. The only people that can merge pull requests are those with write permission. As to the second portion, you can contribute by making said pull requests. I and Pooria are working on an editor for engines.

DDev247 on Aug 11, 2022