amphtml: Running local server on non-localhost causes breakages

Steps to reproduce:

gulp --host=<insert name of host machine>

navigate to hostname:8000/examples/ads.amp.html Select doubleclick for ad network. Notice how all the ads 404

The issue is that non-localhost is not being identified as localDev in mode.js, which is instead hardcoding localhost in its check for localdev mode.

About this issue

  • Original URL
  • State: closed
  • Created 7 years ago
  • Comments: 23 (23 by maintainers)

Most upvoted comments

I believe this is stemming from the hardcoded check for localhost here: https://github.com/ampproject/amphtml/blob/master/src/mode.js#L79