amphtml: amp-list: [src] changes don't properly dispose old bindings

I am currently facing a Maximum number of bindings reached (2000). Additional elements with bindings will be ignored issue.

based on my research, at [bind-impl.js#L532] (https://github.com/ampproject/amphtml/blob/master/extensions/amp-bind/0.1/bind-impl.js#L532) will change the limitExceeded from false to true, and this causes me an error which is = 106 + 1 > 106 when i am trying to select countries on my 4th or 5th times. ss1 ss2 ss3

can you please elaborate more on the L530, what is this IF statement checking bindings.length + boundProperties.length > limit does ? I am also curious how does this IF check is relevant to 2000 bindings numbers.

Appreciate more sharing from you. Thanks in advanced. @choumx

About this issue

Original URL
State: closed
Created 7 years ago
Comments: 20 (6 by maintainers)

Most upvoted comments

@leonalicious Verified this is fixed on version 1515455265699.

dreamofabear on Jan 9, 2018

Stumbled on a couple more bugs. 😄

Duplicate rescan due to AmpEvents.DOM_UPDATE event.
Duplicate amp-list render/fetch due to race between mutatedAttributesCallback and layoutCallback.

dreamofabear on Jan 6, 2018

Thanks for sharing that example. This is definitely a bug and can be fixed.

dreamofabear on Jan 5, 2018

A demo page has been set up at https://randomtestapp-a5a6f.firebaseapp.com/amp-binding-limit-exceeds-issue.html. It contains a master amp-list and a detail amp-list, and clicking between items in the master amp-list will trigger a “Max number of bindings reached” error.

micyeung on Jan 5, 2018