amphtml: amp-ad does not load doublclick enclosed in amp-experiment if amp-ad js is loaded independently.

Production bug!

We noticed a warning feature_tests/spec_example.html:59:7 The tag 'amp-ad extension .js script' is missing or incorrect, but required by 'amp-ad'. This will soon be an error. (see https://www.ampproject.org/docs/reference/amp-ad.html) [DEPRECATION] and so we added amp-ad as a stand alone script. When we did so non-default doubleclick amp-ad units stopped loading (that is the units whose viewability was dependent on the amp-experiment as opposed to those that were viewable by default)

We’ve reverted the change so I can’t give you a demo link. However this link contain the amp-experiment in question. https://wmur.relaymedia.com/amp/news/man-shot-in-manchester-dies-of-injuries/41679500

About this issue

  • Original URL
  • State: closed
  • Created 8 years ago
  • Comments: 17 (15 by maintainers)

Most upvoted comments

Thanks @jpettitt. @zhouyx and I finally reproduced the issue locally and tracked down the bug. It happens when amp-ad is executed before amp-experiment, when the ad is not visible yet. That explains why removing amp-ad script is a work around, because it delays the loading of amp-ad extension.

The issue is actually known: #4075. I’ll make a fix soon. Thanks for reporting!

/to @lannka @zhouyx can anyone of you look into this?