alacritty: ⌘+m does not minimize window
Which operating system does the issue occur on? macOS Mojave
Not a big deal but for some reason hitting <kbd>⌘</kbd>+<kbd>m</kbd> does not minimize Alacritty’s window. It just sends the character m to stdin.
Maybe this is fixable by adding a custom key binding?
About this issue
- Original URL
- State: closed
- Created 5 years ago
- Comments: 15 (11 by maintainers)
Commits related to this issue
- Add minimize action Fixes #2534 — committed to kchibisov/alacritty by kchibisov 5 years ago
- Add minimize action Fixes #2534 — committed to kchibisov/alacritty by kchibisov 5 years ago
- Add `Minimize` binding action Fixes #2534. — committed to alacritty/alacritty by kchibisov 4 years ago
- Add `Minimize` binding action Fixes #2534. — committed to rodolf0/alacritty by kchibisov 4 years ago
- Add `Minimize` binding action Fixes #2534. — committed to phongnh/alacritty by kchibisov 4 years ago
- Add `Minimize` binding action Fixes #2534. — committed to roychoo/alacritty by kchibisov 4 years ago
@chrisduerr I might take a stab at it. Can you point me to the direction?
I’ve created an issue upstream: https://github.com/rust-windowing/winit/issues/983
Looking into this, it might be a good first issue for anyone interested in contributing to winit, assuming that the feature is accepted. I don’t think this should be too complicated to implement.
I appreciate you looking into this @chrisduerr. Haven’t had the time to give this a shot just yet but it is on my list.
Of course!
First of all, the required winit APIs to modify Window minimized state should be these: https://docs.rs/winit/0.19.1/winit/struct.Window.html#method.show https://docs.rs/winit/0.19.1/winit/struct.Window.html#method.hide
These probably need to be exposed on the
alacritty_terminar/src/window.rsfirst. I think ahidemethod already exists, not sure about showing.Then to hook it all up, the config.yml documentation and the input handling need to be modified. A good reference would be the existing
ToggleFullscreenandToggleSimpleFullscreenbindings. Searching this repo should find all instances of them and just copying what they do should be fine.To go into a bit more detail, you’d need to define an action like this and then bind that action to modify the window like this.
That should basically be it, let me know if you need any more info and I can get into a bit more detail. There usually are people in #alacritty on the freenode IRC too if you need more real-time feedback.