kargo: Unable to run make hack-build-cli

Checklist

  • I’ve searched the issue queue to verify this is not a duplicate bug report.
  • I’ve included steps to reproduce the bug.
  • I’ve pasted the output of kargo version.
  • I’ve pasted logs, if applicable.

Description

This isn’t a bug in Kargo just in the Makefile so only relevant for developers/contributors

When running make hack-build-cli I encounter the following error:

docker run -it --rm -v gomodcache:/home/user/gocache -v /Users/webstradev/development/personal/kargo/:/workspaces/kargo -v /workspaces/kargo/ui/node_modules -w /workspaces/kargo kargo:dev-tools sh -c 'GOOS=darwin GOARCH=arm64 make build-cli' CGO_ENABLED=0 go build \ -ldflags "-w -X github.com/akuity/kargo/internal/version.version= -X github.com/akuity/kargo/internal/version.buildDate=$(date -u +'%Y-%m-%dT%H:%M:%SZ') -X github.com/akuity/kargo/internal/version.gitCommit= -X github.com/akuity/kargo/internal/version.gitTreeState=" \ -o bin/kargo-darwin-arm64 \ ./cmd/cli error obtaining VCS status: exit status 128 Use -buildvcs=false to disable VCS stamping. make: *** [Makefile:109: build-cli] Error 1 make: *** [hack-build-cli] Error 2 webstradev@Eriks-MacBook-Pro kargo %

When I add -buildvcs - false, as the error message suggests it works just fine.

Running make build-cli (without the hack) also works as intended.

Screenshots

Steps to Reproduce

switch to main branch, run make hack-build-cli

Version

Paste the output from `kargo version` here.

not applicable as I can’t successfully build the CLI

Logs

Paste any relevant application logs here.

See description.

About this issue

  • Original URL
  • State: closed
  • Created 3 months ago
  • Comments: 17 (17 by maintainers)

Most upvoted comments

or alternatively i can make a pr to add -buildvcs=false to the goflags

We’re already passing all necessary version info in through other means, so I think I would find this acceptable.

Thank you!

Can you try erasing the node modules directory and then rerunning the command?