babel-plugin-inline-react-svg: [Bugs] 0.5.2 breaking change: Path must be a string. Received undefined
Description
I have been working on a coworker implementation that uses this plugin though I don’t really know about it except my coworker use to have it working.
Reproduction
https://travis-ci.org/yeutech-lab/rollup-umd-documentation/jobs/403153237#L1155
This guy helped me found the error: https://github.com/splunk/battlecat-poll/issues/3
Proposed solution
Downgrade to 0.5.1
:
$ npm uninstall babel-plugin-inline-react-svg --save-dev \
&& npm install babel-plugin-inline-react-svg@0.5.1 --save-dev
About this issue
- Original URL
- State: closed
- Created 6 years ago
- Comments: 18
Commits related to this issue
- fix(babel-plugin-inline-react-svg): due to issue https://github.com/airbnb/babel-plugin-inline-react-svg/issues/47 — committed to yeutech-lab/rollup-umd-documentation by deleted user 6 years ago
- chore(release): 2.3.10 [skip ci] ## [2.3.10](https://github.com/yeutech-lab/rollup-umd-documentation/compare/v2.3.9...v2.3.10) (2018-07-13) ### Bug Fixes * **babel-plugin-inline-react-svg:** due to... — committed to yeutech-lab/rollup-umd-documentation by semantic-release-bot 6 years ago
- fix(dependencies): Upgrade babel-plugin-inline-react-svg to 0.5.4 (fix https://github.com/airbnb/babel-plugin-inline-react-svg/issues/47)) — committed to yeutech-lab/rollup-umd-documentation by deleted user 6 years ago
- chore(release): 2.3.19 [skip ci] ## [2.3.19](https://github.com/yeutech-lab/rollup-umd-documentation/compare/v2.3.18...v2.3.19) (2018-07-30) ### Bug Fixes * **alias:** Added $PACKAGE_NAME as a vali... — committed to yeutech-lab/rollup-umd-documentation by semantic-release-bot 6 years ago
v0.5.4 is released.
Thanks, that pinpointed it -
export const pkg = require(path.join(pkgBase, 'package.json'));
(ie, a dynamic require) broke it. I should be able to make a test case from that.I didn’t realize but it is possible for you to validate your fix prior release because the project is on GitHub, see how we fixed the
0.5.1
here: https://github.com/yeutech-lab/rollup-umd-documentation/blob/master/package.json#L172