meta-raspberrypi: Switching from rocko to master on rpi-0w breaks wifi

Description

Changing from latest on rocko to latest on master makes it so that the wlan0 interface doesn’t show up anymore.

Steps to reproduce the issue:

pull latest master
build rpi-hwup-image
run ip link or anything that lists the interfaces, only l0 shows up

Describe the results you received: wlan0 isn’t connected

Describe the results you expected: wlan0 should be present.

Additional information you deem important (e.g. issue happens only occasionally):

Switching back to rocko without changing anything makes it work again.

Additional details (revisions used, host distro, etc.): I also tried updating poky to master and it didn’t improve anything. The reason I’m updating to master is to make use of #183

About this issue

Original URL
State: closed
Created 6 years ago
Comments: 45 (31 by maintainers)

Commits related to this issue

linux-firmware: fix addition of NVRAM file to image (fixes #184) Signed-off-by: Hugo Hromic <hhromic@gmail.com> — committed to agherzan/meta-raspberrypi by hhromic 6 years ago
linux-firmware: fix addition of NVRAM file to image (fixes #184) Signed-off-by: Hugo Hromic <hhromic@gmail.com> — committed to agherzan/meta-raspberrypi by hhromic 6 years ago

Most upvoted comments

Hi all again. I think I pin-pointed the problem now. The commit 61c2a96 introduced an rpi-specific condition for the linux-firmware. However, this block:

FILES_${PN}-bcm43430_rpi += " \
    ${nonarch_base_libdir}/firmware/brcm/brcmfmac43430-sdio.txt \
"

Is not adding the brcmfmac43430-sdio.bin file in the final package. If I remove the condition _rpi it works fine again. Also, if I keep the condition but I add the binary file explicitly, like this:

FILES_${PN}-bcm43430_rpi += " \
    ${nonarch_base_libdir}/firmware/brcm/brcmfmac43430-sdio.bin \
    ${nonarch_base_libdir}/firmware/brcm/brcmfmac43430-sdio.txt \
"

it works too. I’m not sure what would be the correct solution. The _rpi condition should be kept as this is a customisation only necessary for rpi devices. But FILES_${PN}-bcm43430 should contain the binary file already as it has without the _rpi conditional.

Perhaps BitBake is parsing this in a way we are not considering?

Also, if we mirror this block:

SRC_URI_append_rpi = " \
    file://brcmfmac43430-sdio.bin \
    file://brcmfmac43430-sdio.txt \
"

We perhaps should keep both files in FILES_${PN}-bcm43430 as well.

What do you suggest @kraj , @agherzan , @mirzak , @martingkelly (original commit author) ? I can create a PR according to your comments and we can merge it. This will fix bringing up Wifi (and potentially bluetooth) in master.

hhromic on Feb 2, 2018

Oh I see. I will try master now then. But try that of using = instead of += and a leading space before the first package for each _append line you have.

hhromic on Jan 31, 2018