ag-grid: ResizeObserver loop limit exceeded
I’m submitting a … (check one with “x”)
X bug report => see 'Providing a Reproducible Scenario'
[] feature request => do not use Github for feature requests, see 'Customers of AG Grid'
[] support request => see 'Requesting Community Support'
Customers of AG Grid
If you are a customer you are entitled to use the AG Grid’s customer support system (powered by Zendesk). Please use that channel for guaranteed response from the AG Grid team with regards bugs, feature requests and support.
Requesting Community Support
If you are not a customer of AG Grid, ag-grid staff will label your issue as managed-by-the-community. This means that AG Grid staff is not going to be actively looking into it and it will get closed if inactive for more than one month. The community is welcome to help with this question/support issue.
Providing a Reproducible Scenario Accepted reproducible scenarios are
- A description of the detailed steps to reproduce your behaviour in one of our examples in the docs.
- A plunker
If you decide to send us a plunkr, from any example in our website use the plunkr button in there to fork your own code by following the steps below:
- Select the framework that is appropriate to you from the drop-down
- Open it in plunker. (Use the button plunker in our example)
- Add your changes so that the behaviour is reproduced
- Save and Freeze the plunker(On the top left corner)
- Send us the link to the plunker(You can copy the URL from the browser)
If reporting a bug make sure to state.
Current behaviour. Expected behaviour. If possible back this up with our docs/examples if possible
Current behavior When loading a grid with 10 or more records, the error “ResizeObserver loop limit exceeded” is displayed on the screen.
In Chrome: ResizeObserver loop limit exceeded at eval (webpack-internal:///./node_modules/webpack-dev-server/client/overlay.js:249:58)
In Firefox: ERROR ResizeObserver loop completed with undelivered notifications.
Expected behavior No error is generated/shown on the screen.
Please tell us about your environment: VueJS 3, webpack
- **AG Grid version: 29.3.3
-
Browser: Google Chrome: Version 112.0.5615.138 (Official Build) (64-bit) Firefox: 112.0.1 (64-bit)
-
Language: [all | TypeScript X.X | ES6/7 | ES5] typescript: 5.0.4 webpack-cli: 5.0.2 es6
About this issue
- Original URL
- State: closed
- Created a year ago
- Reactions: 7
- Comments: 29 (11 by maintainers)
As an update I believe I have a fix that will avoid these errors being thrown without losing any of the improvements removing the debouncing of resizes gave us.
It is currently undergoing testing and review.
As an FYI I am looking into this issue.
I still think the best compromise would be
requestAnimationFrame
.This would solve 2 issues:
ResizeObserver loop limit exceeded
error would be suppressed.We are seeing the same thing regularly since updating to v29.3.x. Thanks @Elysiome for the pointer above - looking at the history of the file, I would bet that this is the change that has started triggering the error for us:
https://github.com/ag-grid/ag-grid/commit/c30b2e4f2118fc6a647987dcc1b289b196db0c00
It happens very regularly but not 100% of the time, and seems easier to reproduce in react dev mode, both of which lead me to think there is a variable timing component. That checks out in my mind with a change like the above, where a debounce was removed as of 29.3.
As an alternative there is also the following gridOption that will disable the use of ResizeObserver and instead uses a polyfill that periodically checks the grid width and height.
If you set this to true then this will avoid the above errors.
https://www.ag-grid.com/javascript-data-grid/grid-options/#reference-miscellaneous-suppressBrowserResizeObserver
@Elysiome unfortunately this is not an option as there are a number of features that depend on this being synchronous. Instead we would be aiming to locate the root cause and apply a fix there instead.
My users also encounter this error in some cases, but I couldn’t say exactly which ones. I only know that it happens when resizing the grid.
This error is a very common error that can be safely ignored (see https://stackoverflow.com/questions/49384120/resizeobserver-loop-limit-exceeded).
But… It would be nice to suppress it directly in the AG Grid code. This can be done easily by wrapping the observer callback in
requestAnimationFrame()
(see https://stackoverflow.com/questions/49384120/resizeobserver-loop-limit-exceeded).Before:
After:
This piece of code should be fixed:
https://github.com/ag-grid/ag-grid/blob/37c1a493642df6f8df406562e7c3bdaa692ef081/grid-community-modules/core/src/ts/misc/resizeObserverService.ts#L17
Got same error with react + ant design + ag-grid version 29.3.0, 29.3.3 and 29.3.4, happens more frequently when open antd modal that contains a grid, it works fine with 29.2.0
Glad this is getting fixed! It’s not limited to react. I’m seeing this error all over in my Angular unit tests when running 29.3.5.
@StephenCooper
The workaround worked for me. +1 on locating “the root cause and apply a fix there instead.”
For the provided reproduction I believe a workaround will be to apply the following property.
I would be interested to know if applying these flags resolve the issues in your applications? There is also a corresponding vertical scroll bar flag but I believe it is the horizontal scrollbar that is responsible for the resize observer loop.
While using the FirstDataRenderedEvent, facing same error (version used 30.0.2)