git-updater: Gitlab with sub-group does not work

Hi @afragen,

With Gitlab new Sub-group feature, the plugin does not handle correctly the path.

If you enter the following plugin URL https://gitlab.com/issue-packagist-784/my_sub_group/test_project.git

The plugin converts it to : https://gitlab.com/issue-packagist--84/my_sub_group/repository/archive.zip?ref=master…

Log

Downloading install package from https://gitlab.com/issue-packagist--84/my_sub_group/repository/archive.zip?ref=master…

Unpacking the package…

The package could not be installed. PCLZIP_ERR_BAD_FORMAT (-10) : Unable to find End of Central Dir Record signature

About this issue

  • Original URL
  • State: closed
  • Created 7 years ago
  • Comments: 35 (21 by maintainers)

Most upvoted comments

The support plugin just bypasses the WP-Cron background API updates. This is perhaps a sign that you are having issues with WP-Cron.

This is now merged into develop. Anyone testing this branch just needs to update when they see the notification and the update will put you back on the develop branch.

@afragen I tested the gitlab-groups branch and it is working ok. I’ve also submitted a new pull request. See if that makes any sense, my thinking could be wrong. see #563

Time to test. Let me know how branch gitlab-groups works.

If your interested I think this is what would need modification, along with parts of Plugin and Theme. https://github.com/afragen/github-updater/blob/develop/src/GitHub_Updater/Base.php#L845

Remember it still needs to work exactly as it currently does. If you could figure out how to create owner, group, repo variables…