temurin-build: Change version block to highlight update, build number and community information
There’s a challenge involved in making version numbers give credit to the produce for Java. The following issue discusses this: https://bugs.openjdk.java.net/browse/JDK-8189761 and a fix was applied for Java 10 and 11 which seems to also be back ported to 9. However, this is not backported to Java 8, so we have some back porting work to do
Our existing 8 builds produce a Java 8 version like this:
openjdk version "1.8.0_181"
OpenJDK Runtime Environment (AdoptOpenJDK) (build 1.8.0_181-13)
OpenJDK 64-Bit Server VM (build 25.181-b13, mixed mode)
However, this is done using a hack which also overrides the java.runtime.name
property, which we don’t want to do as there is tooling in the wild that relies on it.
Now onto what Oracle produces and what we want to produce. Oracle currently produces this:
Java 8:
java version "1.8.0_181"
Java(TM) SE Runtime Environment (build 1.8.0_181-b13)
Java HotSpot(TM) 64-Bit Server VM (build 25.181-b13, mixed mode)
Java 9:
java version "9.0.4"
Java(TM) SE Runtime Environment (build 9.0.4+11)
Java HotSpot(TM) 64-Bit Server VM (build 9.0.4+11, mixed mode)
Java 10:
Interesting how they add the date here
java version "10.0.2" 2018-07-17
Java(TM) SE Runtime Environment 18.3 (build 10.0.2+13)
Java HotSpot(TM) 64-Bit Server VM 18.3 (build 10.0.2+13, mixed mode)
For releases I think AdoptOpenJDK should produce something similar to:
Java 8
openjdk version "1.8.0_181"
OpenJDK Runtime Environment (build 1.8.0_181-b13-adoptopendk)
OpenJDK 64-Bit Server VM (build 25.181-b13, mixed mode)
Java 9
Note patch number is specified in JEP 223 but is rarely used.
java version "9.0.4.<patch number>"
OpenJDK Runtime Environment (build 9.0.4+11-adoptopenjdk)
Java HotSpot(TM) 64-Bit Server VM (build 9.0.4+11, mixed mode)
Java 10
Note date format matches Oracle’s JDK. Note patch number is specified in JEP 223 but is rarely used.
java version "10.0.2.<patch number>" 2018-07-17
OpenJDK Runtime Environment 18.3 (build 10.0.2+13-adoptopenjdk)
OpenJDK 64-Bit Server VM 18.3 (build 10.0.2+13, mixed mode)
For nightlies I think AdoptOpenJDK should produce something similar to:
Java 8
openjdk version "1.8.0_181"
OpenJDK Runtime Environment (build 1.8.0_181-b13-adoptopendk-yyyymmdd)
OpenJDK 64-Bit Server VM (build 25.181-b13, mixed mode)
Java 9
java version "9.0.4.<patch number>"
OpenJDK Runtime Environment (build 9.0.4+11-adoptopenjdk-yyyymmdd)
Java HotSpot(TM) 64-Bit Server VM (build 9.0.4+11, mixed mode)
Java 10
Note date format matches Oracle’s JDK. Note patch number is specified in JEP 223 but is rarely used.
java version "10.0.2.<patch number>" yyyy-mm-dd
OpenJDK Runtime Environment 18.3 (build 10.0.2+13-adoptopenjdk-yyyymmdd)
OpenJDK 64-Bit Server VM 18.3 (build 10.0.2+13, mixed mode)
In conclusion we’ll attempt to match Oracle’s naming conventions as closely as possible to avoid breaking tooling in the wild. We’ll use configure properties for 9+ to create the version string we want and attempt to back port a patch to Java 8 to allow us to do the same thing.
About this issue
- Original URL
- State: closed
- Created 7 years ago
- Comments: 24 (21 by maintainers)
Commits related to this issue
- Modify version strings closes #93 — committed to karianna/temurin-build by karianna 7 years ago
- Merge pull request #97 from karianna/master Modify version strings closes #93 — committed to adoptium/temurin-build by neomatrix369 7 years ago
- Merge pull request #93 from pshipton/vcruntime-1 Specify -with-vcruntime-1-dll= for jdk8 — committed to AdamBrousseau/openjdk-build by AdamBrousseau 9 months ago
@neomatrix369 I think we might need to pair on this and get it resolved. I’ll arrange a time on slack
@karianna Happy to take a look at this issue, lets discuss this next time on slack