aqa-tests: system tests does not take jvm options

The current set up in systemtest playlist.xml will only run no option regardless what <variation> is added. The tests need to be updated to take JVM_OPTIONS.

Also, there is a test called LangLoDaaLoadTest_daaAlladTest. Is it intended or is it typo?

About this issue

Original URL
State: closed
Created 6 years ago
Comments: 28 (26 by maintainers)

Most upvoted comments

@Mesbah-Alam , looking at your console output, you used JAVA_IMPL=openj9 and SPEC=linux_x86-64. That is probably why you have -Xnocompressedrefs appended.

llxia on Mar 9, 2018

This issue talks about -Xcompressedrefs option gets appended, assume its similar for “no” option, looks at JAVA_IMPL.

smlambert on Mar 8, 2018

Using modeXXX as value in <variation> will still result in modes being ignored.

To correct, using ModeXXX as value in <variation> will work as TKG will interpret ModeXXX into corresponding JVM options.

llxia on Mar 9, 2018

No, STF does not need to support modexxx type values.

In fact, we would like to shift all test playlists (including FV ones) away from using that approach, which adds an unnecessary level of indirection and which has no little meaning to open developers that do not know the background of it (and then would have to look at the modes.xml file to understand what each one mapped to).

smlambert on Mar 9, 2018

And if we want to be thorough, we can update the README for JVM_OPTIONS/EXTRA_OPTIONS that -Xnocompressrefs/-Xcompressedrefs values may be overridden depending on what SPEC you run with.

I am not certain how many of the set of pre-existing variations (a.k.a. modes) contained them, but any variations that contained “-Xnocompressedrefs” are invalid for testing the openj9 builds at this time.

smlambert on Mar 9, 2018

@Mesbah-Alam you should not have this issue. The issue has been fixed https://github.com/AdoptOpenJDK/openjdk-tests/pull/294

The problem you are facing is in your personal build. For personal build please setting SPEC as cmpressedref one. /home/jenkins/workspace/test_personal/openjdkbinary/j2sdk-image/jre/bin/…/…/bin/java

sophia-guo on Mar 9, 2018

In this case, we will have two test targets with different suffix. Please refer OpenJ9 test readme for detail.

llxia on Mar 8, 2018

To reply @llxia question,

JCK has the ability to pass in user defined EXTRA_OPTIONS, e.g.

<command>export JAVA_HOME=$(JDK_HOME)$(D)  && \
	perl $(TEST_RESROOT)$(D)..$(D)..$(D)systemtest$(D)stf$(D)stf.core$(D)scripts$(D)stf.pl  \
	-java-args-setup=$(Q)$(EXTRA_OPTIONS)$(Q) \
	-test-root=$(Q)$(TEST_RESROOT)$(D)..$(D)..$(D)systemtest$(D)stf;$(TEST_RESROOT)$(D)..$(D)..$(D)systemtest$(D)openjdk-systemtest$(Q) \
	-systemtest-prereqs=$(Q)$(JCK_ROOT)$(Q)  \
	-results-root=$(REPORTDIR)  \
	-test=Jck -test-args=$(Q)tests=$(JCK_TEST_TARGET),jckversion=$(JCK_VERSION),testsuite=RUNTIME$(Q); \
	$(TEST_STATUS)</command>

The JCK is using -java-args-setup=xxx, and I think other svt tests could use -java-args=xxx

terryzuoty on Mar 8, 2018

Will we run JCK tests with different variations? If so, JCK has the same issue - JVM_OPTIONS is not passed in. fyi @TianyuZuo

I agree with Shelley, testKitGen should not need to have knowledge about stf variable. Alternatively, systemtest can have its own makefile for this. If both system and JCK need it, then maybe a common makefile for system and JCK.

llxia on Mar 8, 2018