stale: New comments do not remove the Stale label

As raised in https://github.com/uber-web/baseui/pull/1892, it seems like new comments do not remove the Stale label. Do we miss anything in our configuration?

name: 'Close stale issues'
on:
  schedule:
    - cron: '0 0 * * *'

jobs:
  stale:
    runs-on: ubuntu-latest
    steps:
      - uses: actions/stale@v1
        with:
          repo-token: ${{ secrets.GITHUB_TOKEN }}
          stale-issue-message: "This issue is stale because it has been open 30 days with no activity. If it's still valid, please remove the stale label or comment on the issue, otherwise this ticket will be closed in 5 days"
          days-before-stale: 30
          days-before-close: 5

About this issue

Original URL
State: closed
Created 5 years ago
Reactions: 12
Comments: 37 (2 by maintainers)

Commits related to this issue

Attempt to use a fork for stale https://github.com/actions/stale/issues/21 https://github.com/gatsbyjs/stale/blob/128ed907d5174a32717e7761e63294f5c747d8e2/src/main.ts#L122-L130 https://help.git... — committed to eileenmcnaughton/nz.co.fuzion.extendedreport by eileenmcnaughton 5 years ago

Most upvoted comments

I agree this should be done. I’ll add it to the list (I’m actively reviving this repo since it was somewhat stale a while ago).

hross on Apr 16, 2020

You can use our fork if you want: https://github.com/gatsbyjs/stale It’s been working great for us. Since the repo still seems inactive a PR seems unfeasible - we’d be happy to send it in though.

LekoArts on Mar 3, 2020

Just discovering this and yeah, it’s much needed, because if users are not able to stop the countdown, then as a maintainer I’d probably want the issue to be closed right away instead.

I think the issue is just that the label isn’t cleared, the script still checks for the last updated date on the issue so a user commenting resets the counter, it just doesn’t also clear the flag (which may or may not be a good thing depending on how you like your labels to work)

TheSalesOpsGuy on Apr 20, 2020

Does this problem still exist? See https://github.com/helm/helm/issues/4262#issuecomment-767414363

rdxmb on Jan 26, 2021

Yeah - it ignores the author from what I can see!

homotechsual on Jul 9, 2020

@damccorm PR is up over here (not quite working yet): https://github.com/actions/stale/pull/58 if you want to review it

hross on May 2, 2020

I’d also be interested in knowing if this is a bug or user error.

LekoArts on Sep 27, 2019