WpfHexEditorControl: Potential wrong GetSelectionLength method in ByteProvider.cs ?

In ByteProvider.cs / GetSelectionLength() method (line #692) the test for no selection seems incorrect.

It is: if (selectionStop == -1 || selectionStop == -1) …

Shouldn’t it be ? “if (selectionStart == -1 || selectionStop == -1) …”

About this issue

  • Original URL
  • State: closed
  • Created 5 years ago
  • Comments: 16 (9 by maintainers)

Most upvoted comments

Super !

Je continue d’explorer ta réalisation qui, je dois le dire, est rare.

Christian HOSTELET - Grenoble

De : Derek Tremblay notifications@github.com Envoyé : samedi 13 avril 2019 13:39 À : abbaye/WpfHexEditorControl WpfHexEditorControl@noreply.github.com Cc : Christian Hostelet christian.hostelet@free.fr; Author author@noreply.github.com Objet : Re: [abbaye/WpfHexEditorControl] Potential wrong GetSelectionLength method in ByteProvider.cs ? (#41)

Corrigé!

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/abbaye/WpfHexEditorControl/issues/41#issuecomment-482801747 , or mute the thread https://github.com/notifications/unsubscribe-auth/AHS31rmi0dWncgmjARPOLQYiiYJ024QHks5vgcHvgaJpZM4ccSFF .