cs2-dumper: Breaking Changes in the Latest Merge to Main Branch
In the recent merge of the dev
branch into main
, several breaking changes may impact some people relying on the generated files for inclusion in their projects.
Most notably:
Code Style Conventions
Generated files now follow specific code style conventions depending on the programming language:
- C++ header files: Use
snake_case
naming convention, where words are separated by underscores (e.g.,field_name
). - C# files: Follow the
PascalCase
convention, where each word, including the first, starts with an uppercase letter (e.g.,FieldName
). - Rust files: Employ a combination of
snake_case
for variables and functions (e.g.,field_name
) andUPPER_CAMEL_CASE
for constants (e.g.,CONSTANT_NAME
).
// Edit: No longer applies to class, field or enum names.
Consolidated Schema System Data
Previously, any module containing any schema-system registrations was written independently as a separate file, e.g., client.dll.hpp
. The new approach consolidates all schema-system related data into a single file, E.g. schema.hpp
. Within this file, modules are now separated into different scopes.
This change was aimed at eventually making it easier to include the generated files in your project.
Current known issues:
- Empty comments are generated for certain fields.
Please provide any suggestions for improvements below.
About this issue
- Original URL
- State: closed
- Created 3 months ago
- Reactions: 1
- Comments: 24 (9 by maintainers)
i need client.dll & offsets.json
this is a really bad update not going to lie. stuffing a bunch of files into one file and making it 20,445 lines was not the solution. what’s going to happen is a big split, people using the old version of the dumper, and the new one. personally, i will be sticking with the old one.
I pushed the most recently generated files from the previous codebase to the archive branch.
Thanks to everyone for your feedback.
I think this can be closed now, as all of the “controversial” changes have essentially been reverted.
If you have any new suggestions for improvements to the repo, please open a new issue. 👍
I already undid that change.
Regarding schema file generation, I’ve now reverted to the previous method of creating a new file for each module. I’ll push these changes shortly.
I’m considering going back to the prior approach for this. However, doing this did have its reasons at the time.
Would like to know others thoughts.
this is better than the new system
I can’t find many offsets